Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add process added to local Register synchronously #2

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Add process added to local Register synchronously #2

merged 1 commit into from
Oct 28, 2022

Conversation

studzien
Copy link
Collaborator

This PR should fix an issue where a process is registered with {:via, Horde.Registry}, but a subsequent lookup still returns an empty list (because right now, add is asynchronous).

This causes a problem with a :gen_statem implementation, that sometimes fail start_link, if the whereis_name returns :undefined, after register_name was called.

@studzien studzien requested a review from arkgil October 28, 2022 12:57
@studzien studzien merged commit 197bfab into master Oct 28, 2022
studzien added a commit that referenced this pull request Oct 2, 2024
@studzien
Add process added to local Register synchronously (#2)
132c6b5
studzien added a commit that referenced this pull request Oct 2, 2024
@studzien
Revert "Add process added to local Register synchronously (#2)"
8fbaf33 
This reverts commit 132c6b5.
@studzien studzien mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkgil arkgil arkgil approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@studzien @arkgil