Add file_put_contents() & file_get_contents() #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDGrimes
approved these changes
Dec 30, 2016
jrfnl
requested changes
Dec 30, 2016
|
@jrfnl Yes, and I saw that as well, but it is for a different reason (fetching URLs). So it needs to be in both lists. |
grappler
force-pushed
the
feature/file-functions
branch
from
8d4d6d6
to
5b7e5e8
Compare
Good point. In that case the unit tests needs to be adjusted. Edit: Duh me. Just noticed that @grappler had already adjusted the PR to do just that. ;-) |
jrfnl
approved these changes
Dec 31, 2016
grappler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was looking at WPTT/WPThemeReview#79 I realized I missed two functions.
This is also part of the Theme Check plugin and the VIP Scanner https://vip.wordpress.com/documentation/vip/code-review-what-we-look-for/#filesystem-writes
https://github.com/WordPress/theme-check/blob/master/checks/malware.php#L9
https://github.com/Automattic/vip-scanner/blob/master/vip-scanner/checks/VIPRestrictedCommandsCheck.php#L143
Ref: #633