Fix custom properties whitelist in valid variable name sniff #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of the `customPropertiesWhitelist` property of the `WordPress.NamingConventions.ValidVariableName` sniff was always being discarded. This is because the logic that was intended to only be dealing with a non-array value was actually being applied even when the value was properly set as an array. I noticed this while running against a rulseset that utilizes this property, and so I fixed it, and now it is working properly. Apparently this isn't covered by the tests, which only cover the sniffs themselves and not rulesets. Not sure if there is a way to remedy that right now or not.
GaryJones
approved these changes
Feb 9, 2017
|
@JDGrimes I've got a PR ready (waiting for #833 to be merged) which will actually fix this for all sniffs using custom lists which need to be merged. If you don't mind, I'd be inclined to close this one in favour of the more comprehensive one I've got waiting to be pulled. Oh and it includes unit tests ;-) |
|
Ok, the above mentioned branch has now been pulled as PR #841 |
|
@JDGrimes Just doing some clean up. Can I delete this branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of the
customPropertiesWhitelistproperty of theWordPress.NamingConventions.ValidVariableNamesniff was always being discarded. This is because the logic that was intended to only be dealing with a non-array value was actually being applied even when the value was properly set as an array. (See line 299.) I noticed this while running against a rulseset that utilizes this property, and so I fixed it, and now it is working properly.Apparently this isn't covered by the tests, which only cover the sniffs themselves and not rulesets. Not sure if there is a way to remedy that right now or not.