Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom properties whitelist in valid variable name sniff #839

Closed
wants to merge 1 commit into from
Closed

Fix custom properties whitelist in valid variable name sniff #839

wants to merge 1 commit into from

Commits on Feb 9, 2017

  1. Fix custom properties whitelist 

    The value of the `customPropertiesWhitelist` property of the `WordPress.NamingConventions.ValidVariableName` sniff was always being discarded. This is because the logic that was intended to only be dealing with a non-array value was actually being applied even when the value was properly set as an array. I noticed this while running against a rulseset that utilizes this property, and so I fixed it, and now it is working properly.

Apparently this isn't covered by the tests, which only cover the sniffs themselves and not rulesets. Not sure if there is a way to remedy that right now or not.
    @JDGrimes
    JDGrimes committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    b54422b View commit details
    Browse the repository at this point in the history