Skip to content

Commit

Permalink
Fully remove Navigation Editor screen and associated `edit-navigation…
Browse files Browse the repository at this point in the history
…` package (#47055)

* Removes package files

* Remove PHP files

* Remove package from deps

* Tidy config files

* Remove references

* Remove tests

* Remove styles

* Update package lock

* Remove redundant test snap

* Restore removals from snapshot as unrelated to actual code.
  • Loading branch information
getdave authored Jan 26, 2023
1 parent e5b286f commit 38a95a6
Show file tree
Hide file tree
Showing 92 changed files with 4 additions and 7,576 deletions.
5 changes: 0 additions & 5 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,6 @@ const restrictedImports = [
message:
"edit-widgets is a WordPress top level package that shouldn't be imported into other packages",
},
{
name: '@wordpress/edit-navigation',
message:
"edit-navigation is a WordPress top level package that shouldn't be imported into other packages",
},
];

module.exports = {
Expand Down
3 changes: 0 additions & 3 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@
/packages/customize-widgets @noisysocks
/packages/widgets @noisysocks

# Navigation
/packages/edit-navigation @draganescu @talldan @tellthemachines @adamziel @kevin940726 @getdave

# Full Site Editing
/packages/edit-site

Expand Down
8 changes: 4 additions & 4 deletions bin/plugin/commands/test/__snapshots__/changelog.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = `
- Fix block appender position in classic themes. ([33895](https://github.com/WordPress/gutenberg/pull/33895))
- Fix misspelling of \\"queries\\" in filter documentation. ([33799](https://github.com/WordPress/gutenberg/pull/33799))
- Fix positioning discrepancy with draggable chip. ([33893](https://github.com/WordPress/gutenberg/pull/33893))
- Navigation Editor: Avoid React warning when creating a new menu. ([33843](https://github.com/WordPress/gutenberg/pull/33843))
#### Block Library
- Fix justification for button block when selected. ([33739](https://github.com/WordPress/gutenberg/pull/33739))
Expand Down Expand Up @@ -71,10 +72,6 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = `
#### CSS & Styling
- Fix navigation block placeholder preview markup. ([33963](https://github.com/WordPress/gutenberg/pull/33963))
#### Navigation Screen
- Fix regressed menu selection dropdown placeholder value for Nav Editor menu locations UI. ([33748](https://github.com/WordPress/gutenberg/pull/33748))
- Navigation Editor: Avoid React warning when creating a new menu. ([33843](https://github.com/WordPress/gutenberg/pull/33843))
#### Site Editor
- Fix the site editor breaking in firefox. ([33896](https://github.com/WordPress/gutenberg/pull/33896))
Expand All @@ -87,6 +84,9 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = `
#### Build Tooling
- Readable JS assets Plugin: Fix webpack 5 support. ([33785](https://github.com/WordPress/gutenberg/pull/33785))
#### Navigation Screen
- Fix regressed menu selection dropdown placeholder value for Nav Editor menu locations UI. ([33748](https://github.com/WordPress/gutenberg/pull/33748))
#### Accessibility
- Fix some JAWS bugs. ([33627](https://github.com/WordPress/gutenberg/pull/33627))
Expand Down
27 changes: 0 additions & 27 deletions bin/plugin/commands/test/fixtures/pull-requests.json
Original file line number Diff line number Diff line change
Expand Up @@ -5099,24 +5099,6 @@
"color": "d93f0b",
"default": false,
"description": "An existing feature is broken."
},
{
"id": 2074073931,
"node_id": "MDU6TGFiZWwyMDc0MDczOTMx",
"url": "https://api.github.com/repos/WordPress/gutenberg/labels/[Feature]%20Navigation%20Screen",
"name": "[Feature] Navigation Screen",
"color": "fbca04",
"default": false,
"description": "A new block-based screen intended to replace nav-menus.php."
},
{
"id": 2536082965,
"node_id": "MDU6TGFiZWwyNTM2MDgyOTY1",
"url": "https://api.github.com/repos/WordPress/gutenberg/labels/[Package]%20Edit%20Navigation",
"name": "[Package] Edit Navigation",
"color": "ed2572",
"default": false,
"description": "/packages/edit-navigation"
}
],
"state": "closed",
Expand Down Expand Up @@ -8617,15 +8599,6 @@
"color": "fbca04",
"default": false,
"description": "A new block-based screen intended to replace nav-menus.php."
},
{
"id": 2536082965,
"node_id": "MDU6TGFiZWwyNTM2MDgyOTY1",
"url": "https://api.github.com/repos/WordPress/gutenberg/labels/[Package]%20Edit%20Navigation",
"name": "[Package] Edit Navigation",
"color": "ed2572",
"default": false,
"description": "/packages/edit-navigation"
}
],
"state": "closed",
Expand Down
9 changes: 0 additions & 9 deletions lib/client-assets.php
Original file line number Diff line number Diff line change
Expand Up @@ -385,15 +385,6 @@ function gutenberg_register_packages_styles( $styles ) {
);
$styles->add_data( 'wp-list-reusable-block', 'rtl', 'replace' );

gutenberg_override_style(
$styles,
'wp-edit-navigation',
gutenberg_url( 'build/edit-navigation/style.css' ),
array( 'wp-components', 'wp-block-editor', 'wp-editor', 'wp-edit-blocks' ),
$version
);
$styles->add_data( 'wp-edit-navigation', 'rtl', 'replace' );

gutenberg_override_style(
$styles,
'wp-edit-site',
Expand Down
173 changes: 0 additions & 173 deletions lib/experimental/navigation-page.php

This file was deleted.

1 change: 0 additions & 1 deletion lib/load.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ function gutenberg_is_experiment_enabled( $name ) {
}
require __DIR__ . '/experimental/blocks.php';
require __DIR__ . '/experimental/navigation-theme-opt-in.php';
require __DIR__ . '/experimental/navigation-page.php';
require __DIR__ . '/experimental/kses.php';

// Fonts API.
Expand Down
29 changes: 0 additions & 29 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"@wordpress/deprecated": "file:packages/deprecated",
"@wordpress/dom": "file:packages/dom",
"@wordpress/dom-ready": "file:packages/dom-ready",
"@wordpress/edit-navigation": "file:packages/edit-navigation",
"@wordpress/edit-post": "file:packages/edit-post",
"@wordpress/edit-site": "file:packages/edit-site",
"@wordpress/edit-widgets": "file:packages/edit-widgets",
Expand Down
2 changes: 0 additions & 2 deletions packages/base-styles/_z-index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ $z-layers: (
".components-popover.interface-more-menu__content": 99998,
".components-popover.block-editor-rich-text__inline-format-toolbar": 99998,
".components-popover.block-editor-warning__dropdown": 99998,
".components-popover.edit-navigation-menu-actions__switcher-dropdown": 99998,

".components-autocomplete__results": 1000000,

Expand Down Expand Up @@ -170,7 +169,6 @@ $z-layers: (
".components-circular-option-picker__option.is-pressed": 1,
// Needs to be higher than .components-circular-option-picker__option.is-pressed.
".components-circular-option-picker__option.is-pressed + svg": 2,
".edit-navigation-layout__overlay": 999,

// Appear under the customizer heading UI, but over anything else.
".customize-widgets__topbar": 8,
Expand Down
2 changes: 0 additions & 2 deletions packages/block-library/src/navigation/menu-items-to-blocks.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ function mapMenuItemsToBlocks( menuItems, level = 0 ) {
* For more documentation on the individual fields present on a menu item please see:
* https://core.trac.wordpress.org/browser/tags/5.7.1/src/wp-includes/nav-menu.php#L789
*
* Changes made here should also be mirrored in packages/edit-navigation/src/store/utils.js.
*
* @typedef WPNavMenuItem
*
* @property {Object} title stores the raw and rendered versions of the title/label for this menu item.
Expand Down

This file was deleted.

Loading

1 comment on commit 38a95a6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 38a95a6.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4014227090
📝 Reported issues:

Please sign in to comment.