Font Families and Faces: disable autosaves using empty class (#58018)

WordPress · Jan 22, 2024 · d45d540 · d45d540
1 parent 51345f0
commit d45d540
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 28 deletions.
diff --git a/lib/experimental/fonts/font-library/class-wp-rest-autosave-fonts-controller.php b/lib/experimental/fonts/font-library/class-wp-rest-autosave-fonts-controller.php
diff --git a/lib/experimental/fonts/font-library/font-library.php b/lib/experimental/fonts/font-library/font-library.php
@@ -49,7 +49,8 @@ function gutenberg_init_font_library_routes() {
 		'show_in_rest'                   => true,
 		'rest_base'                      => 'font-families',
 		'rest_controller_class'          => 'WP_REST_Font_Families_Controller',
-		'autosave_rest_controller_class' => 'WP_REST_Autosave_Fonts_Controller',
+		// Disable autosave endpoints for font families.
+		'autosave_rest_controller_class' => 'stdClass',
 	);
 	register_post_type( 'wp_font_family', $args );
 
@@ -83,7 +84,8 @@ function gutenberg_init_font_library_routes() {
 			'show_in_rest'                   => true,
 			'rest_base'                      => 'font-families/(?P<font_family_id>[\d]+)/font-faces',
 			'rest_controller_class'          => 'WP_REST_Font_Faces_Controller',
-			'autosave_rest_controller_class' => 'WP_REST_Autosave_Fonts_Controller',
+			// Disable autosave endpoints for font faces.
+			'autosave_rest_controller_class' => 'stdClass',
 		)
 	);
 

diff --git a/lib/load.php b/lib/load.php
@@ -157,7 +157,6 @@ function gutenberg_is_experiment_enabled( $name ) {
 		require __DIR__ . '/experimental/fonts/font-library/class-wp-rest-font-families-controller.php';
 		require __DIR__ . '/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php';
 		require __DIR__ . '/experimental/fonts/font-library/class-wp-rest-font-collections-controller.php';
-		require __DIR__ . '/experimental/fonts/font-library/class-wp-rest-autosave-fonts-controller.php';
 		require __DIR__ . '/experimental/fonts/font-library/font-library.php';
 	}
 

diff --git a/phpunit/tests/fonts/font-library/wpRestFontFacesController.php b/phpunit/tests/fonts/font-library/wpRestFontFacesController.php
@@ -111,6 +111,22 @@ public function test_register_routes() {
 		);
 	}
 
+	public function test_font_faces_no_autosave_routes() {
+		// @core-merge: Enable this test.
+		$this->markTestSkipped( 'This test only works with WP 6.4 and above. Enable it once 6.5 is released.' );
+		$routes = rest_get_server()->get_routes();
+		$this->assertArrayNotHasKey(
+			'/wp/v2/font-families/(?P<font_family_id>[\d]+)/font-faces/(?P<id>[\d]+)/autosaves',
+			$routes,
+			'Font faces autosaves route exists.'
+		);
+		$this->assertArrayNotHasKey(
+			'/wp/v2/font-families/(?P<font_family_id>[\d]+)/font-faces/(?P<parent>[\d]+)/autosaves/(?P<id>[\d]+)',
+			$routes,
+			'Font faces autosaves by id route exists.'
+		);
+	}
+
 	/**
 	 * @covers WP_REST_Font_Faces_Controller::get_context_param
 	 */

diff --git a/phpunit/tests/fonts/font-library/wpRestFontFamiliesController.php b/phpunit/tests/fonts/font-library/wpRestFontFamiliesController.php
@@ -126,6 +126,22 @@ public function test_register_routes() {
 		);
 	}
 
+	public function test_font_families_no_autosave_routes() {
+		// @core-merge: Enable this test.
+		$this->markTestSkipped( 'This test only works with WP 6.4 and above. Enable it once 6.5 is released.' );
+		$routes = rest_get_server()->get_routes();
+		$this->assertArrayNotHasKey(
+			'/wp/v2/font-families/(?P<id>[\d]+)/autosaves',
+			$routes,
+			'Font families autosaves route exists.'
+		);
+		$this->assertArrayNotHasKey(
+			'/wp/v2/font-families/(?P<parent>[\d]+)/autosaves/(?P<id>[\d]+)',
+			$routes,
+			'Font families autosaves by id route exists.'
+		);
+	}
+
 	/**
 	 * @covers WP_REST_Font_Families_Controller::get_context_param
 	 */