Font Families and Faces: disable autosaves using empty class

[creativecoder]

What?

• Revises wp_font_family and wp_font_face post type registration to use an empty class to disable autosave routes
• Adds tests that autosave routes are not registered

Why?

Autosaves are not appropriate for fonts because they are settings rather than content. Having your font settings automatically saved while editing them could be unpleasantly surprising!

How?

Autosaves are disabled by providing a valid, empty class that doesn't extend WP_REST_Controller when registering the post type.

Testing Instructions

• Make a GET request to wp/v2
• See that the routes do not include autosave endpoints for font families or faces (e.g. /wp/v2/font-families/(?P<id>[\d]+)/autosaves is not present)

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/experimental/fonts/font-library/font-library.php
❔ lib/load.php
❔ phpunit/tests/fonts/font-library/wpRestFontFacesController.php
❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController.php

[matiasbenedetto]

This works as advertised, though I didn't see this technique used on the WordPress core codebase. Still, it is a shorter solution than the current one, which consists of creating an empty class, so I approve the PR.

[creativecoder]

I didn't see this technique used on the WordPress core codebase

The closest examples I see in Core are

• wp_global_styles, which declares show_in_rest as false, so doesn't have automatic autosave routes added
• attachment, which is manually excluded in WP_Post_Type::get_autosave_rest_controller

So perhaps our font post types could be excluded like attachments, as well. But until then, I think the solution here makes sense.

[creativecoder]

It turns out that autosave_rest_controller_class was introduced only in WP 6.4, so the tests added here are failing with WP 6.3, since there's no way to disable the autosave routes with that version.

I'm skipping those tests, for now so that CI will pass, but added a core-merge comment to enable them, and made it clear they can be enabled in Gutenberg once WP 6.5 is released.