Font Library: add wp_font_face post type and scaffold font face REST API controller #57656

creativecoder · 2024-01-09T01:39:34Z

What?

Adds a wp_font_face custom post type, which will be used to store installed font faces
Scaffolds a WP_REST_Font_Faces_Controller with basic functionality, which we can build upon in subsequent PRs

The following routes are implemented:

GET wp/v2/font-families/<id>/font-faces
GET wp/v2/font-families/<id>/font-faces/<id>
POST wp/v2/font-families/<id>/font-faces
DELETE wp/v2/font-families/<id>/font-faces/<id>

Why?

This is a step toward refactoring the Font Library API endpoints to implement the proposed design.

Testing Instructions

Check that you can access all of the routes as a an administrator user to read, create, and delete font face posts

Testing Instructions for Keyboard

n/a

github-actions · 2024-01-09T01:40:44Z

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php
❔ phpunit/tests/fonts/font-library/wpRestFontFacesController.php
❔ lib/experimental/fonts/font-library/font-library.php
❔ lib/load.php

creativecoder · 2024-01-09T01:40:30Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+/**
+ * Class to access font faces through the REST API.
+ */
+class WP_REST_Font_Faces_Controller extends WP_REST_Posts_Controller {


I suspect we will move to directly extending WP_REST_Controller eventually, but for now extending the posts controller gives basic endpoint functionality.

creativecoder · 2024-01-09T01:45:34Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+	public function get_font_faces_permissions_check( $request ) {
+		$post_type = get_post_type_object( $this->post_type );
+
+		if ( ! current_user_can( $post_type->cap->edit_posts ) ) {


I'm using the capabilities registered with the post type to check permissions here, so that creating font families in PHP will also be limited by the appropriate user caps.

creativecoder · 2024-01-09T01:49:08Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+	protected function check_is_post_type_allowed( $post_type ) {
+		return true;
+	}


This is needed because show_in_rest is false when registering wp_font_face (see the comment there). Otherwise the parent WP_REST_Posts_Controller:: check_is_post_type_allowed will not allow accessing this post type through the REST API.

If we eventually move to not using WP_REST_Posts_Controller as a parent class, this method can be removed.

creativecoder · 2024-01-09T01:52:22Z

lib/experimental/fonts/font-library/font-library.php

+			'public'          => false,
+			'_builtin'        => true,                              /* internal use only. don't use this when registering your own post type. */
+			'hierarchical'    => false,
+			'show_in_rest'    => false,


Setting show_in_rest to true has some undesired side effects, mainly it creates wp/v2/types/wp_font_face, which we don't want or need, as this is not a typical post type for user content.

So I'm setting show_in_rest to false and manually registering the routes, below.

creativecoder · 2024-01-09T01:54:51Z

phpunit/tests/fonts/font-library/wpRestFontFacesController.php

@@ -0,0 +1,266 @@
+<?php


These tests were largely copied from existing controller tests, like the revisions controller, as a starting point we can add to as the functionality is expanded.

creativecoder · 2024-01-09T02:13:15Z

lib/experimental/fonts/font-library/font-library.php

+			'capabilities' => array(
+				'read'                   => 'edit_theme_options',
+				'read_post'              => 'edit_theme_options',
+				'read_private_posts'     => 'edit_theme_options',
+				'create_posts'           => 'edit_theme_options',
+				'edit_post'              => 'edit_theme_options',
+				'edit_posts'             => 'edit_theme_options',
+				'publish_posts'          => 'edit_theme_options',
+				'edit_published_posts'   => 'edit_theme_options',
+				'delete_posts'           => 'edit_theme_options',
+				'delete_post'            => 'edit_theme_options',
+				'delete_published_posts' => 'edit_theme_options',
+				'edit_others_posts'      => 'edit_theme_options',
+				'delete_others_posts'    => 'edit_theme_options',
+			),


I'm mapping all of the capabilities for wp_font_face to use edit_theme_options, since that's what we're currently using for the font library, but these should be changed to a font specific capability, once we have that in place.

mikachan

I've tested that I can access the following:

GET wp/v2/font-families/<id>/font-faces ✅
GET wp/v2/font-families/<id>/font-faces/<id> ✅
POST wp/v2/font-families/<id>/font-faces ✅
DELETE wp/v2/font-families/<id>/font-faces/<id> ✅

I've also tested:

New posts are saved as wp_font_face post type ✅
Get a 401 error when hitting the endpoints while not logged in as an admin ✅
Get an invalid/missing parent ID error when requesting an invalid parent ID ✅
Do not get a handled error response when requesting an invalid font face ID ❌

When I requested a valid font face via wp/v2/font-families/<id>/font-faces/<id>, I'm only seeing the id, parent, and _link data (which all look correct). I'm missing theme_json_version and font_face_settings, as the post content is empty. Just checking that this is expected (or if I've done the POST request wrong!)

This is looking like a great start for the font face endpoints. From what I've tested above, I think it would be nice to also handle an invalid font face ID similar to how the invalid parent ID is handled.

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

creativecoder · 2024-01-09T15:47:48Z

Thanks for the review @mikachan !

I think it would be nice to also handle an invalid font face ID similar to how the invalid parent ID is handled.

Good idea. That happens in parent::get_item, but belongs as an earlier check, so I've added it. You should now get the standard rest_post_invalid_id with a 404 status.

When I requested a valid font face via wp/v2/font-families//font-faces/, I'm only seeing the id, parent, and _link data (which all look correct). I'm missing theme_json_version and font_face_settings, as the post content is empty. Just checking that this is expected (or if I've done the POST request wrong!)

No, that's correct--there's no data handling for theme_json_version or font_face_settings yet to keep things simple in this PR.

mikachan · 2024-01-09T16:31:22Z

You should now get the standard rest_post_invalid_id with a 404 status.

Nice, can confirm I'm seeing that now. Thanks!

matiasbenedetto · 2024-01-10T13:55:29Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+						),
+					),
+				),
+				'allow_batch' => $this->allow_batch,


Both /font-families/ and /font-faces/ API paths will accept files. Since the batch framework doesn't work with files. Could we delete this property and use the default, false?

Good call. I know we previously discussed using the batch API for font faces, but it's not very useful without file uploads support. I'll remove this.

matiasbenedetto · 2024-01-10T13:55:52Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+					'permission_callback' => array( $this, 'create_item_permissions_check' ),
+					'args'                => $this->get_endpoint_args_for_item_schema( WP_REST_Server::CREATABLE ),
+				),
+				'allow_batch' => $this->allow_batch,


Both /font-families/ and /font-faces/ API paths will accept files. Since the batch framework doesn't work with files. Could we delete this property and use the default, false?

matiasbenedetto · 2024-01-10T13:56:46Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+	 * @param WP_Post_Type|string $post_type Post type name or object.
+	 * @return bool Whether the post type is allowed in REST.
+	 */
+	protected function check_is_post_type_allowed( $post_type ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable -- required by parent class


Not sure why this is hardcoded to true.

This is a side affect of inheriting from WP_REST_Posts_Controller as an easy way of getting started. I think we'll go directly to using WP_REST_Controller by the end, and this can be removed.

What is this method for?

matiasbenedetto · 2024-01-10T14:16:23Z

lib/experimental/fonts/font-library/font-library.php

+			'public'       => false,
+			'_builtin'     => true,                              /* internal use only. don't use this when registering your own post type. */
+			'hierarchical' => false,
+			'show_in_rest' => false,


Not sure why show_in_rest is set to false. It seems contradictory with the function defined after

protected function check_is_post_type_allowed( $post_type ) { return true; }

I'm thinking of it this way: we don't want to manage the wp_font_face post type through the REST API, in the way that one usually would for post types that store user created content. From the perspective of the API consumer, posts for font faces and font families is more of an implementation detail. For example, none of the fields used in other post related endpoints (post_title, post_content, etc) are used in the REST API interface for fonts. We don't want autosaves or revisions, which are typically used with 'show_in_rest' => true,.

This also matches how the wp_global_styles post type is registered, which I think is the one most similar to wp_font_face and wp_font_family. These 3 post types store settings, rather than content.

Another problem is that a side effect of 'show_in_rest' => true, is that the post type is added to the wp/v2/types endpoint, including links that will be incorrect for font faces (wp/v2/font-faces rather than wp/v2/font-families/<id>/font-faces). I don't see a way to correct that with filters, currently.

…API controller (#57656)

spacedmonkey · 2024-01-17T18:22:43Z

lib/experimental/fonts/font-library/font-library.php

+
+	$font_faces_controller = new WP_REST_Font_Faces_Controller();
+	$font_faces_controller->register_routes();


See https://github.com/WordPress/gutenberg/pull/57656/files#r1456254862

spacedmonkey · 2024-01-17T18:23:04Z

lib/experimental/fonts/font-library/font-library.php

+			'_builtin'     => true,                              /* internal use only. don't use this when registering your own post type. */
+			'hierarchical' => false,
+			'show_in_rest' => false,
+			'rest_base'    => 'font-faces',


'rest_controller_class' => "WP_REST_Font_Faces_Controller"

This should have been used here. Not manaul registeration

spacedmonkey · 2024-01-17T18:23:41Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+	public function __construct() {
+		$post_type       = 'wp_font_face';
+		$this->post_type = $post_type;


This should not be needed. The parent class __construct should be used

spacedmonkey · 2024-01-17T18:24:25Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+	 *
+	 * @see register_rest_route()
+	 */
+	public function register_routes() {


This too should just use the parent classes register_routes method. None of this is needed.

spacedmonkey · 2024-01-17T18:24:52Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+	 * @param int $parent_post_id Supplied ID.
+	 * @return WP_Post|WP_Error Post object if ID is valid, WP_Error otherwise.
+	 */
+	protected function get_parent( $parent_post_id ) {


Ditto, the parent class method should work here.

Which parent class method do you mean? I'm not seeing anything for getting the parent of a post in WP_REST_Posts_Controller or WP_REST_Controller.

Other controllers I see that use this (Autosaves, Global Styles, Revisions) re-implement the method, so that's the pattern we're following here.

spacedmonkey · 2024-01-17T18:26:48Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+	 *
+	 * @return true|WP_Error True if the request has read access, WP_Error object otherwise.
+	 */
+	public function get_font_faces_permissions_check() {


Let's use remove this method and use the core get_items_permissions_check methods. If the messages need to change, then they those methods can be overridden.

spacedmonkey · 2024-01-17T18:27:05Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+	 * @param WP_Post_Type|string $post_type Post type name or object.
+	 * @return bool Whether the post type is allowed in REST.
+	 */
+	protected function check_is_post_type_allowed( $post_type ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable -- required by parent class


What is this method for?

spacedmonkey · 2024-01-17T18:27:54Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+
+		$font_face = parent::get_item( $request );
+
+		if ( (int) $parent->ID !== (int) $font_face->data['parent'] ) {


Parents may not be in this data, if the _fields parameter is used.

In this case, the $request['parent'] comes from the font family parent id route arg, so will always be available. I renamed in a later PR to $request['font_family_id'] try and reduce confusion.

Parents may not be in this data, if the _fields parameter is used.

I see now that you mean $font_face->data['parent']. I'll address this by checking $post->post_parent directly.

spacedmonkey · 2024-01-17T18:29:03Z

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php

+					'items'       => array(
+						'type'                 => 'object',
+						'properties'           => array(
+							'fontFamily'            => array(


snake case should be used for all these properties.

…API controller (#57656)

* Font Library: add wp_font_face post type and scaffold font face REST API controller (#57656) * Font Library: create font faces through the REST API (#57702) * Refactor Font Family Controller (#57785) * Font Family and Font Face REST API endpoints: better data handling and errors (#57843) * Font Families REST API endpoint: ensure unique font family slugs (#57861) * Font Library: delete child font faces and font assets when deleting parent (#57867) Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com> * Font Library: refactor client side install functions to work with revised API (#57844) * Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) --------- Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com> * Cleanup/font library view error handling (#57926) * Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) * moved response processing into the resolver for fetchGetFontFamilyBySlug * Moved response processing for font family installation to the resolver * Refactored font face installation process to handle errors more cleanly * Cleanup error handling for font library view * Add i18n function to error messages * Add TODO comment for uninstall notice --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Fix unique key prop warning when opening modal * Add key props to FontsGrid children * Font Faces endpoint: prevent creating font faces with duplicate settings (#57903) * Font Library: Update uninstall/delete on client side (#57932) * Fix delete endpoint * Update fetchUninstallFontFamily to match new format * Update uninstallFont * Add uninstall notice back in * Tidy up comments * Re-word uninstall notices * Add spacing to error message * Refactored how font family values were processed so they would retain their id, which is now used to delete a font family without fetching data via slug * Rename uninstallFont to uninstallFontFamily * Throw uninstall errors rather than returning them --------- Co-authored-by: Jason Crist <jcrist@pbking.com> * Add slug/id back to FontCollection * Change tabsFromCollections inline with Font Collections PR * Use child.key for key prop in FontsGrid * Update packages/edit-site/src/components/global-styles/font-library-modal/local-fonts.js Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com> * Font Library: address JS feedback in #57688 (#57961) * Wrap error messages in sprintf * Use await rather than then * Add variables for API URLs * Update packages/edit-site/src/components/global-styles/font-library-modal/resolvers.js Co-authored-by: Jeff Ong <jonger4@gmail.com> --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> * Font Library REST API endpoints: address initial feedback from feature branch (#57946) * Font Library: font collection refactor to use the new schema (#57884) * google fonts collection data provisional url * rename controller methods * fix get_items parameters * fix endpoint return * rafactor font collection class * fix tests for the refactored class * refactor font collections rest controller * update font collection tests * update the frontend to use the new endpoint data schema * format php * adding linter line ignore rul * replacing throwing an exception by calling doing_it_wrong * add translation marks Co-authored-by: Jeff Ong <jonger4@gmail.com> * user ternary operator * correct translation formatting and comments * renaming function * renaming tests * improve url matching Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> * return error without rest_ensure_response * fix contradictory if condition --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> * Remove old WP_REST_Autosave_Fonts_Controller class --------- Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> Co-authored-by: Grant Kinney <hi@grant.mk> Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com> Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>

* Font Library: add wp_font_face post type and scaffold font face REST API controller (#57656) * Font Library: create font faces through the REST API (#57702) * Refactor Font Family Controller (#57785) * Font Family and Font Face REST API endpoints: better data handling and errors (#57843) * Font Families REST API endpoint: ensure unique font family slugs (#57861) * Font Library: delete child font faces and font assets when deleting parent (#57867) * Font Library: refactor client side install functions to work with revised API (#57844) * Cleanup/font library view error handling (#57926) * Font Faces endpoint: prevent creating font faces with duplicate settings (#57903) * Font Library: Update uninstall/delete on client side (#57932) * Font Library: address JS feedback in #57688 (#57961) * Font Library REST API endpoints: address initial feedback from feature branch (#57946) * Font Library: font collection refactor to use the new schema (#57884) * Fix font asset download when font faces are installed (#58021) * Font Families and Faces: disable autosaves using empty class (#58018) * Adds migration for legacy font family content (#58032) --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com> Co-authored-by: Sarah Norris <sarah@sekai.co.uk> Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>

* Font Library: add wp_font_face post type and scaffold font face REST API controller (#57656) * Font Library: create font faces through the REST API (#57702) * Refactor Font Family Controller (#57785) * Font Family and Font Face REST API endpoints: better data handling and errors (#57843) * Font Families REST API endpoint: ensure unique font family slugs (#57861) * Font Library: delete child font faces and font assets when deleting parent (#57867) Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com> * Font Library: refactor client side install functions to work with revised API (#57844) * Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) --------- Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com> * Cleanup/font library view error handling (#57926) * Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) * moved response processing into the resolver for fetchGetFontFamilyBySlug * Moved response processing for font family installation to the resolver * Refactored font face installation process to handle errors more cleanly * Cleanup error handling for font library view * Add i18n function to error messages * Add TODO comment for uninstall notice --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Font Faces endpoint: prevent creating font faces with duplicate settings (#57903) * Font Library: Update uninstall/delete on client side (#57932) * Fix delete endpoint * Update fetchUninstallFontFamily to match new format * Update uninstallFont * Add uninstall notice back in * Tidy up comments * Re-word uninstall notices * Add spacing to error message * Refactored how font family values were processed so they would retain their id, which is now used to delete a font family without fetching data via slug * Rename uninstallFont to uninstallFontFamily * Throw uninstall errors rather than returning them --------- Co-authored-by: Jason Crist <jcrist@pbking.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/local-fonts.js Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com> * Font Library: address JS feedback in #57688 (#57961) * Wrap error messages in sprintf * Use await rather than then * Add variables for API URLs * Update packages/edit-site/src/components/global-styles/font-library-modal/resolvers.js Co-authored-by: Jeff Ong <jonger4@gmail.com> --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> * Add missing dep in font-demo * Move notice to top of local-fonts panel * Add container around spinner * Move notice to TabPanelLayout * Remove spacer from LocalFonts * Move notice and setNotice state to context.js * Move spacer outside of notice container * Rename LocalFonts to UploadFonts * Make notices dismissible * Reset notices onRemove * Reset notice when new tab is selected * Reset notice on each action * Fix notice re-render on fetchFontCollection * Move notices below font collection title and description --------- Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> Co-authored-by: Grant Kinney <hi@grant.mk> Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com> Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>

creativecoder added 3 commits January 8, 2024 19:18

Adds wp_font_face post type and REST API controller

11af824

Adds a basic set of controller tests for WP_REST_Font_Faces_Controller

3c2fc75

Override GET collection args

a3e494c

creativecoder added REST API Interaction Related to REST API [Feature] Typography Font and typography-related issues and PRs labels Jan 9, 2024

creativecoder self-assigned this Jan 9, 2024

creativecoder requested a review from spacedmonkey as a code owner January 9, 2024 01:39

Adds missing property comment

894f198

creativecoder commented Jan 9, 2024

View reviewed changes

Tweaks and cleanup

c0739dc

creativecoder requested review from pbking, matiasbenedetto, mikachan and jffng January 9, 2024 02:10

creativecoder added the [Type] Experimental Experimental feature or API. label Jan 9, 2024

creativecoder commented Jan 9, 2024

View reviewed changes

creativecoder added 3 commits January 8, 2024 20:20

Fix phpcs error and warnings

56823bc

Correct typo

88eb462

Fix remaining phpcs warnings

1de34f4

mikachan reviewed Jan 9, 2024

View reviewed changes

lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php Outdated Show resolved Hide resolved

Add error for invalid font face id

ee7a0b8

creativecoder changed the base branch from trunk to try/font-library-refactor January 9, 2024 16:55

mikachan approved these changes Jan 9, 2024

View reviewed changes

creativecoder merged commit e17a0bf into try/font-library-refactor Jan 9, 2024
55 checks passed

creativecoder deleted the add/font-faces-post-type-and-controller branch January 9, 2024 16:57

creativecoder mentioned this pull request Jan 10, 2024

Font Library: create font faces through the REST API #57702

Merged

matiasbenedetto reviewed Jan 10, 2024

View reviewed changes

creativecoder added a commit that referenced this pull request Jan 12, 2024

Font Library: add wp_font_face post type and scaffold font face REST …

c8072d4

…API controller (#57656)

spacedmonkey reviewed Jan 17, 2024

View reviewed changes

creativecoder added a commit that referenced this pull request Jan 22, 2024

Font Library: add wp_font_face post type and scaffold font face REST …

5dbb7fc

…API controller (#57656)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Font Library: add wp_font_face post type and scaffold font face REST API controller #57656

Font Library: add wp_font_face post type and scaffold font face REST API controller #57656

creativecoder commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

creativecoder Jan 9, 2024

creativecoder Jan 9, 2024

creativecoder Jan 9, 2024

creativecoder Jan 9, 2024

creativecoder Jan 9, 2024

creativecoder Jan 9, 2024 •

edited

Loading

mikachan left a comment •

edited

Loading

creativecoder commented Jan 9, 2024

mikachan commented Jan 9, 2024

matiasbenedetto Jan 10, 2024

creativecoder Jan 10, 2024

matiasbenedetto Jan 10, 2024

matiasbenedetto Jan 10, 2024

creativecoder Jan 10, 2024

spacedmonkey Jan 17, 2024

matiasbenedetto Jan 10, 2024

creativecoder Jan 10, 2024

spacedmonkey Jan 17, 2024

spacedmonkey Jan 17, 2024

spacedmonkey Jan 17, 2024

spacedmonkey Jan 17, 2024

spacedmonkey Jan 17, 2024

creativecoder Jan 18, 2024

spacedmonkey Jan 17, 2024

spacedmonkey Jan 17, 2024

spacedmonkey Jan 17, 2024

creativecoder Jan 18, 2024

creativecoder Jan 18, 2024

spacedmonkey Jan 17, 2024


		$font_faces_controller = new WP_REST_Font_Faces_Controller();
		$font_faces_controller->register_routes();


		$font_face = parent::get_item( $request );

		if ( (int) $parent->ID !== (int) $font_face->data['parent'] ) {

Font Library: add wp_font_face post type and scaffold font face REST API controller #57656

Font Library: add wp_font_face post type and scaffold font face REST API controller #57656

Conversation

creativecoder commented Jan 9, 2024

What?

Why?

Testing Instructions

Testing Instructions for Keyboard

github-actions bot commented Jan 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

creativecoder Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

mikachan left a comment • edited Loading

Choose a reason for hiding this comment

creativecoder commented Jan 9, 2024

mikachan commented Jan 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

creativecoder Jan 9, 2024 •

edited

Loading

mikachan left a comment •

edited

Loading