Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right-align small images pinned to top-left of boxblock #3945

Closed
2 tasks
GaryJones opened this issue Dec 12, 2017 · 1 comment · Fixed by #5973
Closed
2 tasks

Right-align small images pinned to top-left of boxblock #3945

GaryJones opened this issue Dec 12, 2017 · 1 comment · Fixed by #5973
Labels
[Feature] Media Anything that impacts the experience of managing media Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Milestone
Merge: Media

Comments

@GaryJones
Copy link
Member

GB 1.9.0

Issue Overview

Images are pinned to the top-left of their containing blocks, even when set as right-aligned.

Steps to Reproduce (for bugs)

  1. Open demo content.
  2. Resize an image to be smaller than the width of the image toolbar.
  3. Right align image.
  4. Toggle between selecting the image and not.

Notice the jumping image.

Expected Behavior

If an image is right-aligned, keep the image pinned to the top right of it's container when the container needs to stay wide enough to allow for all of the tools.

Current Behavior

Toggling selection of small right-aligned images gives a jarring jump, compared to small left-aligned images.

Possible Solution

Pin right-aligned images to the right side of it's container.

Screenshots / Video

gb-right-aligned-jump

Related Issues and/or PRs

This issue is probably a more fundamental version of #3944 which reports on lack of pinning to the right of right-aligned images when resizing.

Todos

  • Tests
  • Documentation
@mtias mtias added [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement. labels Jan 3, 2018
@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time and removed [Type] Enhancement A suggestion for improvement. labels Jan 23, 2018
@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@harsh-barach
Copy link

@karmatosed @danielbachhuber @mtias @GaryJones I have solved the issue. ( #5164 )

@pento pento mentioned this issue Feb 23, 2018
Closed
3 tasks
jasmussen pushed a commit that referenced this issue Apr 4, 2018
Fix various image width problems
418342d 
This fixes #3945 and #5213. It is a new PR that is meant to replace #5209. This PR is a work in progress.
@jasmussen jasmussen mentioned this issue Apr 4, 2018
Merged
@karmatosed karmatosed modified the milestones: Merge Proposal, Merge Proposal: Media Apr 12, 2018
jasmussen added a commit that referenced this issue Apr 13, 2018
@jasmussen
Improve image figure widths, remove inline styles (#5973)
2dc9fb3 
* Fix various image width problems

This fixes #3945 and #5213. It is a new PR that is meant to replace #5209. This PR is a work in progress.

* Remove inline style for unscaled images.

Also fix placeholder.

* Restore float widths for blocks without intrinsice width

Affects CoverImage, Gallery, Embed. This moves those styles to each blocks individual stylesheet.

* Remove inline style on figure for scaled images

With the presence of `fit-content` applied to the figure, the explicit inline style is no longer required.
@danielbachhuber danielbachhuber mentioned this issue May 10, 2018
Closed
@naiba4 naiba4 mentioned this issue May 13, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Media Anything that impacts the experience of managing media Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Merge: Media
Development

Successfully merging a pull request may close this issue.

Improve image figure widths, remove inline styles WordPress/gutenberg
5 participants
@danielbachhuber @GaryJones @karmatosed @mtias @harsh-barach