Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the style.scss to solve issue (#3945) #5164

Conversation

harsh-barach
Copy link

Description

I have changed the style.scss to solve the issue. I have added css property to right align the image when the image-block is on right-aligned.

How Has This Been Tested?

I have tested in my local copy.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [Yes] My code is tested.
  • [Yes] My code follows the WordPress code style.
  • [Yes] My code has proper inline documentation.

@harsh-barach harsh-barach changed the title updated the style.scss to solve issue updated the style.scss to solve issue (#3945) Feb 20, 2018
@aduth
Copy link
Member

aduth commented Feb 23, 2018

I have added css property to right align the image when the image-block is on right-aligned.

I see padding changes, not alignment? And for the default block appender, not the image block?

Were these the intended changes?

@harsh-barach
Copy link
Author

@aduth According to my css image block is aligned to Right hand site. I think it is scss so need to compile to apply css changes. Because i have checked by adding the css into blocks/build/style.css. Is it right way to add css in style.css. If so, then i can edit my pull request and resubmit.

@aduth
Copy link
Member

aduth commented Mar 7, 2018

Changes should not be made to the .css files, as they are generated automatically by the build step, and are not included in the source of the git repository. That may explain why I am unable to see your proposed changes here.

@harsh-barach
Copy link
Author

@aduth thanks for the reply. So, in which file should i made css changes? I have doubt on that because lots of css changes i want to do for another issue as well. Please guide me.

@aduth
Copy link
Member

aduth commented Mar 15, 2018

You should only be editing SCSS files for stylesheets. For the image block, that might be this one:

https://github.com/WordPress/gutenberg/blob/master/blocks/library/image/style.scss

If you're not familiar with Sass, there's a basics guide here:

https://sass-lang.com/guide

The CSS files are output during the build step (npm run dev), which is covered in more detail here:

https://github.com/WordPress/gutenberg/blob/master/CONTRIBUTING.md

@danielbachhuber
Copy link
Member

danielbachhuber commented May 10, 2018

Closing in favor of #5973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants