-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button: Replace remaining 40px default size violations #65018
Comments
Hi @mirka, I would like to pick up the task related to Update: Here is the PR for updating the Thank You, I would like to pick |
Thank you so much for all your help, everyone! 🥹 It's super helpful because we'd like to land all these in time for WP 6.7. We'll get your PRs reviewed promptly. |
Hi @mirka, I am picking Thank You, |
I just noticed that the 40px size warning doesn't seem to be applied to the For example, here we have a If I comment out this rule, the 40px size warning seems to apply to the Is it intentional that the warning doesn't appear in the |
Hmm, this actually looks unintended, as if the theme var rules unintentionally overwrote the temp migration ones. Here's what happens when we enable the temp rules for the components package:
|
Inspired by #65140 (comment), after all PRs are merged, we should also check that there are no usages left of |
Part of #63871
Throughout the app, there are still 167 instances of
Button
that use the old 36px default size. For consistency, we need to switch all these to the new 40px size.Since this is a manual process requiring visual inspection of all instances, I broke the task down into manageable chunks so multiple people can work on it in parallel.
How to submit PRs
In the PR, post a review comment for each changed file including brief testing instructions and before/after screenshots.
See #64524 for an example.
Chunked tasks by package
To pick up a task, write your name by the checklist item or post a comment to this issue.
block-directory (@vipul0425 Fix: Button Replace remaining 40px default size violations [Block Directory] #65467)
Details
block-editor 1 (@vipul0425 Fix: Button Replace remaining 40px default size violations [Block Editor 1]. #65034 )
Details
block-editor 2 (@dhruvang21 Fix: Button Replace remaining 40px default size violations [Block Editor 2] #65308)
Details
block-editor 3 (@vipul0425 Fix: Button Replace remaining 40px default size violations [Block Editor 3] #65225)
Details
block-editor 4 (@vipul0425 Fix: Button Replace remaining 40px default size violations [Block Editor 4] #65257)
Details
block-editor 5 (@PARTHVATALIYA Fix: Button Replace remaining 40px default size violations [Block Editor 5] #65361)
Details
block-editor 6
Details
block-library 1 (@hbhalodia Fix: Button: Replace remaining 40px default size violations [Block library 1] #65033)
Details
block-library 2 (@hbhalodia Fix: Button: Replace remaining 40px default size violation [Block library] #65075)
Details
block-library 3 (@hbhalodia , Fix: Button: Replace remaining 40px default size violation [Block library 3] #65110)
Details
block-library 4 (@hbhalodia Fix: Button: Replace remaining 40px default size violation [Block library 4] #65143)
Details
customize-widgets, edit-post
Details
edit-site 1 (@hbhalodia Fix: Button: Replace remaining 40px default size violation [Edit Site 1] #65226)
Details
edit-site 2 (@hbhalodia Fix: Button: Replace remaining 40px default size violation [Edit Site 2] #65258)
Details
edit-site 3 (@hbhalodia Fix: Button: Replace remaining 40px default size violation [Edit Site 3] #65309)
Details
edit-widgets (@dhruvang21 Fix: Button Replace remaining 40px default size violations [Edit widgets] #65367)
Details
editor 1 (@AKSHAT2802 Add props for buttons in editor 1 #65068)
Details
editor 2 (@AKSHAT2802 Add props for buttons in editor 2 #65083)
Details
editor 3 (@AKSHAT2802 Add __next40pxDefaultSize for files in editor 3 #65139)
Details
editor 4 (@AKSHAT2802 Add __next40pxDefaultSize for files in editor 4 #65140)
Details
dataviews, list-reusable-blocks, nux, reusable-blocks
Details
The text was updated successfully, but these errors were encountered: