ToggleGroupControl: Add lint rule for 40px size prop usage #64524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +66 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
28 tasks
mirka
commented
Aug 15, 2024
| @@ -125,6 +125,7 @@ export default { | |||
| ) } | |||
| { allowJustification && ( | |||
| <ToggleGroupControl | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
This can be seen for example in the Group block.
| Before | After |
|---|---|
 |
 |
| @@ -325,6 +325,7 @@ function FlexLayoutJustifyContentControl( { | |||
|
|
|||
| return ( | |||
| <ToggleGroupControl | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
This can be seen for example in the Row block.
| Before | After |
|---|---|
 |
 |
| @@ -449,6 +449,7 @@ function GridLayoutTypeControl( { layout, onChange } ) { | |||
|
|
|||
| return ( | |||
| <ToggleGroupControl | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
This can be seen in the Grid block.
| Before | After |
|---|---|
 |
 |
| @@ -10,6 +10,7 @@ import { | |||
| export function CommentsPaginationArrowControls( { value, onChange } ) { | |||
| return ( | |||
| <ToggleGroupControl | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Insert Comments block, and click the pagination block inside it.
| Before | After |
|---|---|
 |
 |
| @@ -626,10 +626,11 @@ function Navigation( { | |||
| </div> | |||
| </> | |||
| ) } | |||
| <h3>{ __( 'Overlay Menu' ) }</h3> | |||
There was a problem hiding this comment.
Moving this unnecessary h3 to a label on ToggleGroupControl.
There was a problem hiding this comment.
I'd be curious (and also a bit scared) to see how many more h3s are being used as labels (since the styles are the same)
There was a problem hiding this comment.
😅
May be alleviated if we add fieldset/legend support to BaseControl (or provide a new component for it)? Like the h3 below this is used as a heading for multiple ToggleControls.
There was a problem hiding this comment.
Yeah, it definitely sounds like we need to gather and brainstorm all requirements that we'd like for a new version of BaseControl. Support for fieldset/legend and for multiple/composed inputs seem to be important and more frequent that we thought
| <ToggleGroupControl | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
See the "Settings" tab in the inspector for the Navigation block.
| Before | After |
|---|---|
 |
 |
| @@ -203,6 +203,7 @@ const DimensionControls = ( { | |||
| panelId={ clientId } | |||
| > | |||
| <ToggleGroupControl | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Choose an Aspect ratio that's not "Original".
| Before | After |
|---|---|
 |
 |
| @@ -120,6 +120,7 @@ export default function PostNavigationLinkEdit( { | |||
| /> | |||
| ) } | |||
| <ToggleGroupControl | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
This can be seen in the Next Post and Previous Post blocks.
| Before | After |
|---|---|
 |
 |
| @@ -10,6 +10,7 @@ import { | |||
| export function QueryPaginationArrowControls( { value, onChange } ) { | |||
| return ( | |||
| <ToggleGroupControl | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Insert a Query Loop block, choose something with a pagination block in it, and select that pagination block.
| Before | After |
|---|---|
 |
 |
mirka
commented
Aug 15, 2024
| __nextHasNoMarginBottom | ||
| className="wp-block-navigation__overlay-menu-icon-toggle-group" |
There was a problem hiding this comment.
A bit of style wrangling going on here. See screenshot above.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
Aug 15, 2024
| @@ -626,10 +626,11 @@ function Navigation( { | |||
| </div> | |||
| </> | |||
| ) } | |||
| <h3>{ __( 'Overlay Menu' ) }</h3> | |||
There was a problem hiding this comment.
I'd be curious (and also a bit scared) to see how many more h3s are being used as labels (since the styles are the same)
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63871
What?
Add a lint rule to prevent people from introducing new usages of ToggleGroupControl that do not adhere to the new default size.
Testing Instructions
The lint error should trigger for violations as expected.