Fix: Button Replace remaining 40px default size violations [Block Editor 4] #65257
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| __next40pxDefaultSize={ false } | ||
| { ...propsWithTabIndex } | ||
| > | ||
| <Button __next40pxDefaultSize { ...propsWithTabIndex }> |
There was a problem hiding this comment.
The custom style height: auto is causing it to be 90px, so __next40pxDefaultSize has no effect in this case. I have not changed the styles as it was looking good. Let me know if anything needs to be changed.
| @@ -15,8 +15,7 @@ function PatternCategoriesList( { | |||
| { patternCategories.map( ( { name, label } ) => { | |||
| return ( | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -61,8 +61,7 @@ function BlockPatternsTab( { | |||
| { children } | |||
| </CategoryTabs> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -110,8 +109,7 @@ function InsertExternalImageModal( { onClose, onSubmit } ) { | |||
| </FlexItem> | |||
| <FlexItem> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -71,8 +71,7 @@ function MediaTab( { | |||
| allowedTypes={ ALLOWED_MEDIA_TYPES } | |||
| render={ ( { open } ) => ( | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -138,8 +138,7 @@ export default function QuickInserter( { | |||
|
|
|||
| { setInserterIsOpened && ( | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
I have removed the custom CSS for height as it was overriding the default size styles. Let me know if any further changes are needed.
Thanks 🙇
| Before | After |
|---|---|
Part of - #65018
What?
This would fix in that in subtask
block-editor-4.Why?
To make the consistent button across Gutenberg, and we would have a lint rule added once fixed, all the button usage.
How?
Change from
__next40pxDefaultSize={ false }to__next40pxDefaultSizeon component.Testing Instructions
Testing steps and screenshots are added below.