-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block library: Introduce block.json metadata for all client side blocks #14770
Conversation
9fe927f
to
73424ca
Compare
73424ca
to
565618e
Compare
packages/e2e-tests/fixtures/blocks/core__image__center-caption.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this iterative approach. I left a few questions. I also saw that you didn't move the file block attributes because of the i18n issue, we should try the solution discussed in #core-js here.
Yes, Tabel and File blocks have some challenges which I plan to resolve later this week. Update: File block is being addressed in #14862. Table block is being addressed in #14863. |
7616373
to
45723df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's iterate 👍
45723df
to
3de1a78
Compare
Description
This PR is a follow-up for #14551 which introduced a way to inline
block.json
metadata.Scope covered by this PR:
block.json
files for the following fields:name
category
attributes
There were 2 exceptions where I couldn't easily move
attributes
to JSON file:default
value for an attribute (https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/file/index.js#L64-L69)I opened separate PRs for them: #14862 and #14863.
How has this been tested?
npm run test
npm run dev
and ensure all blocks work as before.