Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes column import on native #14880

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fixes column import on native #14880

merged 1 commit into from
Apr 9, 2019

Conversation

koke
Copy link
Contributor

@koke koke commented Apr 9, 2019 •
edited
Loading

The changes in #14770 moved the column block from columns/column to column. This fixes the import on the native file.

To test:

@koke koke added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Apr 9, 2019
@koke koke requested a review from hypest April 9, 2019 11:06
@koke koke mentioned this pull request Apr 9, 2019
Merged
hypest
hypest approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest hypest merged commit bb3b77a into master Apr 9, 2019
@hypest hypest deleted the rnmobile/fix-column-import branch April 9, 2019 11:57
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
This was referenced Apr 15, 2019
Merged
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.5 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@koke @hypest @youknowriad