Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement image copy paste on GB-RN mobile #14802

Merged
merged 8 commits into from
Apr 5, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Apr 3, 2019

Description

This PR adds code to handle copy paste of images on the RN mobile apps.

How has this been tested?

This can be tested on the mobile app using this branch: wordpress-mobile/gutenberg-mobile#810

Screenshots

Types of changes

This PR copy the majority of code from the web rich-native component that handle copy paste of files and adapts for mobile. One of the changes needed is to allow copy/paste of file url that are local files in order to allow the import of temporary files that are created on the device.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@SergioEstevao SergioEstevao added Mobile Web Viewport sizes for mobile and tablet devices Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Apr 3, 2019
@SergioEstevao SergioEstevao added this to the 5.5 (Gutenberg) milestone Apr 3, 2019
@SergioEstevao SergioEstevao requested a review from mzorz April 3, 2019 16:48
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goods overall, just left some small comments and questions

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with WPiOS, Thank you @SergioEstevao 👍

@SergioEstevao SergioEstevao merged commit 37bc735 into master Apr 5, 2019
@SergioEstevao SergioEstevao deleted the rnmobile/730_image_copy_paste_2 branch April 5, 2019 09:59
@gziolo gziolo removed the Mobile Web Viewport sizes for mobile and tablet devices label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants