-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement copy/paste of images in the file/binary format #810
Conversation
Sure thing @SergioEstevao ! Thanks for the ping, will put this in my ToDo list and try start tomorrow 👍 |
# Conflicts: # gutenberg
@pinarol do you mind test this on iOS too? |
@SergioEstevao sure thing! I can test this later today or first thing tomorrow. |
Hey @SergioEstevao 👋 I did some testing on this, I can paste multiple images pretty well but after that if I try to copy paste normal text it is not working. Also if the block is empty it is removed after the paste. Other than this I think changes look pretty good. |
@pinarol excellent catch, just updated the code to fix the issue you found. |
Hey @SergioEstevao 👋 Copy paste seems fixed but I just realized the keyboard down button is not working when caret is at the Image caption. This is not happening on develop. |
Sorry wrong alarm with the right steps I could repro that in develop also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 Tested with WPiOS
Generated by 🚫 dangerJS |
Fixes #730
Related Gutenberg PR: WordPress/gutenberg#14802
This PR implements the copy paste of images on the iOS side.
It works by intercepting the paste method on Aztec and passing a url path array to the JS side to import.
It also implements delegate methods to ask the native, host app to import them in any way it wants.
On the demo app we are just simulating an upload, but on the main WP app we should import the media to the site.
To test:
@mzorz do you want to add the android implementation if needed? Can you do copy/paste of a binary image in Android?