Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Making the focus state of button text in Button block more visible #15058

Merged
merged 5 commits into from
Apr 26, 2019
Merged

[Enhancement] Making the focus state of button text in Button block more visible #15058

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d32f50b
Reduce placeholder opacity on focus to make cursor visible
Apr 18, 2019
ba342e9
Make placeholder disappear on focus to make focus-state visible
Apr 19, 2019
51ce5ee
Align cursor to left when text input is focused and placeholder is ac…
Apr 19, 2019
a06f391
Left align text input when placeholder is active at all times, not ju…
Apr 25, 2019
1bd0e74
Added focus outline on focus state
Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/block-library/src/button/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,30 @@
color: $white;
}

// Add outline to button on focus to indicate focus-state
.block-editor-rich-text__editable:focus {
box-shadow: 0 0 0 1px $white, 0 0 0 3px $blue-medium-500;

// Windows' High Contrast mode will show this outline, but not the box-shadow.
outline: 2px solid transparent;
outline-offset: -2px;
}

// Increase placeholder opacity to meet contrast ratios.
.block-editor-rich-text__editable[data-is-placeholder-visible="true"] + .block-editor-rich-text__editable {
opacity: 0.8;
}

// Make placeholder disappear on focus to make focus-state visible.
.block-editor-rich-text__editable[data-is-placeholder-visible="true"]:focus + .block-editor-rich-text__editable {
opacity: 0;
}

// Align cursor to left when placeholder is active.
.block-editor-rich-text__editable[data-is-placeholder-visible="true"] {
text-align: left;
}

// Don't let the placeholder text wrap in the variation preview.
.block-editor-block-preview__content & {
max-width: 100%;
Expand Down Expand Up @@ -66,6 +85,9 @@
$blocks-button__link-input-width: 300px + 2px + 2 * $icon-button-size;
width: $blocks-button__link-input-width;

// Move it down by 2px so that it doesn't overlap the button focus outline.
margin-top: 2px;

.block-editor-url-input {
width: auto;
}
Expand Down