-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds new edit flow to the file block #15515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually — I'm am seeing the issue @talldan reported in the old thread:
The filename and file link isn't updated when adding or replacing a file using 'Insert from URL' (could just use the url).
a9c7167
to
cf70e0d
Compare
@mapk for me it doesn't happen in Firefox 67. What FF do you have? |
b5ddd48
to
3f464e0
Compare
@draganescu I just tested again using FF 67.0.1 and it's working fine. I'm not sure which version I had running when I saw that, but I know I just updated today before testing this out. |
#11952 changed direction so closing this as it became irrelevant. |
Description
Closes #14795
Also fixes #10521
This is a follow up to the image block edit flow update which ports the new flow to all the blocks which have media with an edit state.
How has this been tested?
For now I've only tested locally.
Types of change
New feature (non-breaking change which adds functionality)
Screenshots