-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds new edit flow to the media+text block #15517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me. The only small visual issue I'm seeing is the issue @talldan noted in the original thread:
Some space is needed between the Media Library and Insert From URL buttons (seems to also apply to other blocks). This does seem to be an issue with the image block as well, so could always fix it after this PR for all blocks:
I agree we could fix this separately if it's not a super-quick global fix.
e05e3cf
to
77718ab
Compare
Sounds good. This PR is looking pretty good in that case. The only bug I'm seeing now is that while I can make use of the "Insert from URL" option as when logged in as a Contributor, the cancel link doesn't display under the button: |
I tested this today and it works well. I ran through a few configurations and it was great! Thanks for your work on this @draganescu 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @draganescu the comment I left on the cover block #15519 (review) also applied here. I think we should have a solution used in both blocks.
#11952 changed direction so closing this as it became irrelevant. |
Description
Closes #14795
This is a follow up to the image block edit flow update which ports the new flow to all the blocks which have media with an edit state.
How has this been tested?
For now I've only tested locally.
Types of change
New feature (non-breaking change which adds functionality)
Screenshots