Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile app crashes when the user merges two blocks #16441

Merged
merged 1 commit into from
Jul 6, 2019
Merged

Mobile app crashes when the user merges two blocks #16441

merged 1 commit into from
Jul 6, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Jul 5, 2019 •
edited
Loading

@marecar3 marecar3 self-assigned this Jul 5, 2019
@marecar3 marecar3 changed the title Mobile app crashes when two blocks are merged Mobile app crashes when the user merges two blocks Jul 5, 2019
@marecar3 marecar3 mentioned this pull request Jul 5, 2019
Merged
mchowning
mchowning approved these changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this @marecar3 ! 👏

@marecar3 marecar3 merged commit baa2498 into master Jul 6, 2019
@marecar3 marecar3 deleted the rnmobile/App-crashes-when-two-blocks-are-merged branch July 6, 2019 13:32
@youknowriad youknowriad added this to the Gutenberg 6.1 milestone Jul 8, 2019
daniloercoli added a commit that referenced this pull request Jul 8, 2019
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
279a9ae 
…rnmobile/track-unsupported-blocks

* 'master' of https://github.com/WordPress/gutenberg:
  Bump plugin version to 6.1.0-rc.1
  Update HTML anchor explaination text (#16142)
  Move post permalink to beneath title on mobile. (#16277)
  Export cloneBlock method to the mobile (#16441)
  Fix inconsistent references to Settings Sidebar (#16138)
  Adds a cache key to the blocks reducer in order to optimize the getBlock selector (#16407)
  Track the parent block to optimize hierarchy selectors (#16392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@marecar3 marecar3

Labels
None yet
Projects
None yet
Milestone
Gutenberg 6.1
Development

Successfully merging this pull request may close these issues.

App crashes when two blocks are merged
3 participants
@marecar3 @mchowning @youknowriad