Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile app crashes when the user merges two blocks #1203

Merged
merged 2 commits into from
Jul 6, 2019
Merged

Mobile app crashes when the user merges two blocks #1203

merged 2 commits into from
Jul 6, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Jul 5, 2019 •
edited
Loading

Fixes #1202

Following gutenberg PR: WordPress/gutenberg#16441

To test:

  1. Open Gutenberg Editor
  2. Crete two non-empty paragraph blocks
  3. Merge them

Result: Blocks should be merged with success.

@marecar3 marecar3 self-assigned this Jul 5, 2019
@marecar3 marecar3 mentioned this pull request Jul 5, 2019
Merged
mchowning
mchowning approved these changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected on both platforms!

@marecar3 marecar3 merged commit 7a9a3ea into develop Jul 6, 2019
@marecar3 marecar3 deleted the issue/1202_App-crashes-when-two-blocks-are-merged branch July 6, 2019 13:49
daniloercoli added a commit that referenced this pull request Jul 8, 2019
@daniloercoli
Merge branch 'develop' of https://github.com/wordpress-mobile/gutenbe…
69d43d2 
…rg-mobile into issue/1174-track-unsupported-blocks

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  Mobile app crashes when the user merges two blocks (#1203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

@etoledom etoledom Awaiting requested review from etoledom

Assignees

@marecar3 marecar3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes when two blocks are merged
2 participants
@marecar3 @mchowning