Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/fix duplicate block attr slug #24198

Closed

Conversation

dknieriem
Copy link

Description

Fixes #23978

Updates "Create Block" Tutorial Doc filenames in order to force unique slugs for two "block-attribute" pages

How has this been tested?

  • Ran npm docs:build
  • Verified that all links for the "Create Block" tutorial still work
  • Verified that links to the Blocks API page "block attributes" now link to the correct page

Screenshots

N/A

Types of changes

Docs update

Checklist:

  • My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] My code has proper inline documentation.
  • [n/a] I've included developer documentation if appropriate.
  • [n/a] I've updated all React Native files affected by any refactorings/renamings in this PR.

@ajitbohra
Copy link
Member

ajitbohra commented Jul 24, 2020

maybe we can simply rename slug block-attributes to attributes

cc: @mkaz

@mkaz
Copy link
Member

mkaz commented Jul 28, 2020

@ajitbohra Agreed. Switched in #24244

Thanks for the PR and suggestion, howeverchanging so many links will require putting redirects in place since those pages are already linked elsewhere. It will be easier to just switch to attributes.md and use the longer names in the future.

@mkaz mkaz closed this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to Attributes page in block API has been lost from documentation
4 participants