[RN Mobile] Ube cannot view or interact with the classic block on jetpack sites #26168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marecar3
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
2 tasks
marecar3
changed the title
3 tasks
cameronvoell
approved these changes
Oct 15, 2020
Thanks Cameron.
|
guarani
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Approved via wordpress-mobile/WordPress-Android#13148 (review)
|
We are going to merge this one even we have failed tests as that isn't something which was introduced by this PR. |
marecar3
deleted the
rnmobile/UBE_cannot_view_or_interact_with_the_classic_block_on_jetpack_sites_new
branch
ceyhun
pushed a commit
that referenced
this pull request
Oct 16, 2020
5 tasks
ceyhun
added a commit
that referenced
this pull request
Oct 16, 2020
* Release script: Update react-native-editor version to 1.39.0 * Release script: Update with changes from 'npm run core preios' * Update changelog * Update CHANGELOG.md * Allow to display columns with different unit, set their width in percentages (#26095) * [RN Mobile] UBE - Inject css on both page visible and page started (#26071) * [RN Mobile] Ube cannot view or interact with the classic block on jetpack sites (#26168) * [RNMobile] Correct where appender condition is placed (#26203) Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Marko Savic <savicmarko1985@gmail.com>
ceyhun
added a commit
that referenced
this pull request
Oct 23, 2020
* Release script: Update react-native-editor version to 1.39.0 * Release script: Update with changes from 'npm run core preios' * Update changelog * Update CHANGELOG.md * Allow to display columns with different unit, set their width in percentages (#26095) * [RN Mobile] UBE - Inject css on both page visible and page started (#26071) * [RN Mobile] Ube cannot view or interact with the classic block on jetpack sites (#26168) * [RNMobile] Correct where appender condition is placed (#26203) * Release script: Update react-native-editor version to 1.39.1 * Release script: Update with changes from 'npm run core preios' * Mobile - Heading block - Disable full-width/wide alignment (#26308) * Update CHANGELOG.md Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Marko Savic <savicmarko1985@gmail.com> Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if we have fixed this issue UBE issue: cannot view or interact with the classic block on Jetpack sites
we still had a problem on some devices, like
Galaxy Tab S3@cameronvoell.This PR proposes a new fix that should work for every scenario on every Android device.
Gutenberg mobile PR: wordpress-mobile/gutenberg-mobile#2730
How has this been tested?
Checklist: