Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ube cannot view or interact with the classic block on jetpack sites new #2730

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Fix/ube cannot view or interact with the classic block on jetpack sites new #2730

merged 4 commits into from
Oct 15, 2020

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Oct 15, 2020 •
edited
Loading

Fixes #2695

Fellow Gutenberg PR: WordPress/gutenberg#26168

To test:

  1. On the web, create a post with a classic block on a Jetpack site (note: I used Jetpack 9.0.1 WordPress 5.5.1 in this test).
  2. Save or publish the post.
  3. In the app, open the post from the previous step in the block editor.
  4. Tap on the classic block.
  5. Tap on the classic block again.
  6. Select the option to "Edit using the web editor."
  7. Observe that you are able to load or interact with the classic block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@marecar3 marecar3 requested a review from guarani October 15, 2020 17:21
@marecar3 marecar3 changed the base branch from develop to release/1.38.1 October 15, 2020 17:21
@marecar3 marecar3 self-assigned this Oct 15, 2020
This was referenced Oct 15, 2020
Merged
Merged
cameronvoell
cameronvoell approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#26168 (review)

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 15, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

guarani
guarani approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/WordPress-Android#13148 (review)

@marecar3 marecar3 merged commit a7a3aea into release/1.38.1 Oct 15, 2020
@marecar3 marecar3 deleted the fix/UBE_cannot_view_or_interact_with_the_classic_block_on_jetpack_sites_new branch October 15, 2020 21:39
@cameronvoell cameronvoell mentioned this pull request Oct 15, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@guarani guarani guarani approved these changes

Assignees

@marecar3 marecar3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsupported Block Editor: cannot view or interact with the classic block on Jetpack sites
3 participants
@marecar3 @cameronvoell @guarani