Update Twenty Twenty-One theme references #27770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
I think we'd want to merge both the theme-experiments PR and this very soon after one another to avoid things breaking here. Someone with admin privileges might need to merge this one, as it seems like it wouldn't be possible to get the tests passing here (without merging the other PR, then re-running them, then merging). |
ntsekouras
approved these changes
Dec 17, 2020
mkevins
added a commit
that referenced
this pull request
Dec 21, 2020
* Use LinkSettingsNavigation in Image block * Revert mapping url attribute in link settings * Map url -> href attribute for link picker in image block * Don't overwrite mapped attribute when undefined * Fix lint * Conditionally render link options in link settings * Move link settings panel in image block settings * Auto-hide "Open in new tab" in rich text link settings * Revert "Update tt1 blocks references. (#27770)" This reverts commit c665998. * Revert "Revert "Update tt1 blocks references. (#27770)"" This reverts commit f40b256. * Fix assertion count in multi-entity-saving test This is an attempt to fix a failing test - I manually counted 26 assertions, instead of 27, so it looks correct. However, it still is not clear how this was passing before with 27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
We're updating theme name for the block-based version of Twenty Twenty-One: WordPress/theme-experiments#145
This PR updates the references to match the updated theme slug once that PR lands. I may have missed some references so it would be great to get some eyes from folks who are more familiar with the tests.