-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Underline selected text as soon as LinkTo field is populated #29035
Conversation
24320e0
to
3393be5
Compare
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and is working as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on both platforms and everything works as expected. Good job @lukewalczak
Fixes: wordpress-mobile/gutenberg-mobile#3058
Ref to gb-mobile: wordpress-mobile/gutenberg-mobile#3156
Description
PR introduces the feature to underline the selected text as soon as
Link To
field is populated and clean once it's empty.How has this been tested?
Details
Paragraph
google.com
Expect selected text is underlined
Details
Apply
Expect text isn't underlined
Details
Paragraph
google.com
Expect selected text is underlined
Remove link
Expect text isn't underlined
Details
Paragraph
google.com
Google
Expect selected text is underlined
Details
Expect link is autopopulated and selected text is underlined
Screenshots
Attached above
Types of changes
Feature
Checklist: