Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline selected text when populating link #3156

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

lukewalczak
Copy link
Contributor

Fixes ##3058

Ref to gutenberg: WordPress/gutenberg#29035

To test: steps are described in gutenberg PR

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! WordPress/gutenberg#29035 (review)

(Since you're away a few days I'll help by getting this merged)

@chipsnyder chipsnyder merged commit 098b2bb into develop Feb 18, 2021
@chipsnyder chipsnyder deleted the underline-linked-selected-text branch February 18, 2021 15:42
@enejb enejb mentioned this pull request Mar 1, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants