Blocks: Ensure theme category is only added when not provided #30089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ajitbohra,
chrisvanpatten,
mkaz,
spacedmonkey and
TimothyBJacobs
as code owners
gziolo
force-pushed
the
update/block-categories-theme
branch
from
6860c40 to
2701788
Compare
gziolo
added
[Tool] Create Block
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
ntsekouras
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Great follow up @gziolo ! Thanks for opening the trac ticket too! 💯
carolinan
approved these changes
Mar 22, 2021
|
Side note, but I've been seeing a lingering empty "Uncategorized" group after the theme category was added |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #30020.
This PR ensures
themecategory is only added when not provided for the block type categories. It also adds the new category in several places in the documentation.How has this been tested?
The category in the inserter should look like before:
Types of changes
Refactoring.
Checklist: