Add "theme" category and better present template parts in the inserter #30020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Feature] Block API
mtias
requested review from
ajitbohra,
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
mtias
changed the title
|
Size Change: +35 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Mar 19, 2021
ntsekouras
reviewed
Mar 19, 2021
There was a problem hiding this comment.
The exposure to Inserter needs more stuff (haven't thought of yet) because this is a special case of block variation where the isActive variation is implemented with the area property, that is not in block's attributes.
So by inserting a Header or Footer now, doesn't change anything anywhere and doesn't even set the area on clicking Create new Template Part.
I think we can skip the exposure here and do that in a follow up, or do it here.
|
@ntsekouras agreed, I mentioned it to @Addison-Stavlo and @david-szabo97 that it should probably be an attribute. |
mtias
force-pushed
the
add/theme-blocks-category
branch
from
8fad4b0
to
352f409
Compare
mtias
force-pushed
the
add/theme-blocks-category
branch
from
934ded3
to
1d82324
Compare
7 tasks
|
Core ticket created: https://core.trac.wordpress.org/ticket/52883. |
7 tasks
|
I added some changes to improve integration for the new category: #30089. |
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Mar 23, 2021
Related: WordPress/gutenberg#30020. Introduces a new "theme" category to the default set to use with template-parts and other FSE blocks. Props matveb. Fixes #52883. git-svn-id: https://develop.svn.wordpress.org/trunk@50564 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 23, 2021
Related: WordPress/gutenberg#30020. Introduces a new "theme" category to the default set to use with template-parts and other FSE blocks. Props matveb. Fixes #52883. git-svn-id: https://develop.svn.wordpress.org/trunk@50564 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 23, 2021
Related: WordPress/gutenberg#30020. Introduces a new "theme" category to the default set to use with template-parts and other FSE blocks. Props matveb. Fixes #52883. Built from https://develop.svn.wordpress.org/trunk@50564 git-svn-id: http://core.svn.wordpress.org/trunk@50177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Mar 23, 2021
Related: WordPress/gutenberg#30020. Introduces a new "theme" category to the default set to use with template-parts and other FSE blocks. Props matveb. Fixes #52883. Built from https://develop.svn.wordpress.org/trunk@50564 git-svn-id: https://core.svn.wordpress.org/trunk@50177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
F-Wilke
pushed a commit
to FiliagoDev/WordPress
that referenced
this pull request
Jul 31, 2021
Related: WordPress/gutenberg#30020. Introduces a new "theme" category to the default set to use with template-parts and other FSE blocks. Props matveb. Fixes #52883. Built from https://develop.svn.wordpress.org/trunk@50564 git-svn-id: http://core.svn.wordpress.org/trunk@50177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30016.
This introduces a new "theme" category to the default set and applies it to template-parts and their variations. It also exposes Header and Footer in the inserter and updates the default icon.
Later we should determine if other blocks also belong here (like Navigation).