-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add author name block #36001
Add author name block #36001
Conversation
Size Change: +279 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
remove the stylesheet
@c4rl0sbr4v0, it might be a good idea to check feature parity with the recently updated Comment Author block. We should also consider renaming the comment-related block to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
https://github.com/WordPress/gutenberg/runs/4605782518?check_suite_focus=true It looks like you still need to run |
Yes, I was about to ask @mkaz, then figured out I needed to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work on this one @carolinan! 👍
Description
Split the author name into its own block.
Partial for #35596
A decision is needed about the most appropriate HTML tag for displaying the name.
How has this been tested?
Types of changes
New block
Checklist:
*.native.js
files for terms that need renaming or removal).