Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Add registration of new block for native mobile #37776

Merged
merged 14 commits into from
Jan 19, 2022

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Jan 7, 2022

Description

Registers a new block for native mobile.

How has this been tested?

See wordpress-mobile/gutenberg-mobile#4291.

Types of changes

  • New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

guarani and others added 11 commits September 14, 2021 13:30
* Register new block
* Enable new block capability
* Register new block
* Enable new block capability
…ss/gutenberg into rnmobile/add/tiled-gallery-block
* Register new block
* Enable new block capability
…ss/gutenberg into rnmobile/add/tiled-gallery-block
These files were committed by mistake, after they were automatically generated. This commit reverts their addition.
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this contains all the changes needed to add a new block, release notes aren't necessary as the block isn't a core one and will initially only be available on development builds :shipit:

@guarani
Copy link
Contributor Author

guarani commented Jan 18, 2022

Thanks @SiobhyB!

@guarani guarani merged commit 5b3e5b4 into trunk Jan 19, 2022
@guarani guarani deleted the rnmobile/add/tiled-gallery-block branch January 19, 2022 17:21
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants