Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Port of Jetpack Tiled Gallery Block #15619

Merged
merged 15 commits into from
Jan 19, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Nov 25, 2021

Fixes wordpress-mobile/gutenberg-mobile#4268

This PR brings the first iteration of the Tiled Gallery block to the Android app.

To test: Please refer to the Jetpack PR as the "central PR" with the most up-to-date testing instructions.

Related PRs

Regression Notes

  1. Potential unintended areas of impact

This PR adds a new block, and it is only available on development builds, so there is little potential impact on other parts of the app.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

We just relied on existing Gutenberg Mobile and WPiOS tests.

  1. What automated tests I added (or what prevented me from doing so)

We added a test in wordpress-mobile/gutenberg-mobile#3903 but wordpress-mobile/gutenberg-mobile#4168 needs to be resolved before we can add more tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 25, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 25, 2021

You can test the changes on this Pull Request by downloading the APKs:

@guarani guarani self-requested a review January 13, 2022 19:32
@guarani guarani marked this pull request as ready for review January 13, 2022 19:32
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a test locally and the Square layout works as expected.

We'll have to tag a Gutenberg Mobile release, update this PR, and then merge.

@guarani guarani added this to the 19.1 milestone Jan 19, 2022
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@guarani guarani merged commit 946e761 into trunk Jan 19, 2022
@guarani guarani deleted the rnmobile/add/tiled-gallery-block branch January 19, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Jetpack Phase 1B feature branch into master
2 participants