[RNmobile] Trim feature image copy #37956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnstn
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +640 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
2 tasks
fluiddot
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
I noticed that on iOS, these strings are untranslated when testing the editor with this change. However, this makes sense as the strings have changed, so LGTM 🎊 !
Tested on Samsung Galaxy S20 FE 5G (Android 10).
NOTE: Since this is a user-facing fix, I'm wondering if we should update the react-native-editor changelog, wdyt?
Agreed, thanks for the suggestion! updated in ac10f8392f |
fluiddot
reviewed
Jan 14, 2022
| ## 1.69.0 | ||
|
|
There was a problem hiding this comment.
I noticed that an extra line has been introduced to all sections of the changelog, @jhnstn is this expected?
There was a problem hiding this comment.
yeah I just noticed that, it was auto formatted by VScode. But I just noticed half of the file has the extra whitespace already so I'm thinking keep the extra space. Happy to revert that if you think it's better to have no space.
There was a problem hiding this comment.
I saw that other changelog files have this format (example reference), so looks great to me leaving it this way 👍 .
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a partial fix for wordpress-mobile/gutenberg-mobile#4432
Leaving whitespace at the end of a string causes the translation look up to fail on Android.
While this is not the most robust solution it does fix the two known problem strings.
How has this been tested?
Since this issue only occurs on Android, testing should be done with an Android device or emulator
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).