Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing Featured Image translations #4464

Merged
merged 9 commits into from
Jan 14, 2022
Merged

Fix missing Featured Image translations #4464

merged 9 commits into from
Jan 14, 2022

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Jan 13, 2022 •
edited by fluiddot
Loading

Fix missing translations on Android
See GB : WordPress/gutenberg#37956

Partial Fix for #4432

To test:
See test step on WordPress/gutenberg#37956

NOTE: This issue only affects the Android platform.
(Edited by @fluiddot)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jhnstn
Update Gutenberg submodule
5e1a29c 
Also include the Android strings for verifcation
@jhnstn jhnstn requested a review from fluiddot January 13, 2022 19:57
fluiddot
fluiddot requested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the localization strings file for iOS should be also updated as the string now has a different value (reference). You could update both by running the command npm run i18n:update.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 14, 2022 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

fluiddot
fluiddot reviewed Jan 14, 2022
View reviewed changes
bundle/android/strings.xml Outdated
@@ -142,7 +142,7 @@
<string name="gutenberg_native_duplicate_block" tools:ignore="UnusedResources">Duplicate block</string>
<string name="gutenberg_native_each_block_has_its_own_settings_to_find_them_tap_on_a_block_its_s" tools:ignore="UnusedResources">Each block has its own settings. To find them, tap on a block. Its settings will appear on the toolbar at the bottom of the screen.</string>
<string name="gutenberg_native_edit_cover_media" tools:ignore="UnusedResources">Edit cover media</string>
<string name="gutenberg_native_edit_file" tools:ignore="UnusedResources">Edit file</string>
<string name="gutenberg_native_edit_file" tools:ignore="UnusedResources">Edit file </string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is accurate, this string is referenced here but it doesn't include the extra space 🤔 .

bundle/android/strings.xml Outdated Show resolved Hide resolved
fluiddot
fluiddot approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

Approved via WordPress/gutenberg#37956 (review).

NOTE: I see that the Gutenberg ref is not pointing to the latest commit of WordPress/gutenberg#37956, we should update it once the Gutenberg PR is merged.

@fluiddot fluiddot added this to the 1.70.0 (19.1) milestone Jan 14, 2022
@fluiddot
Copy link
Contributor

@jhnstn I'm wondering if we should update the PR's title in order to describe more accurately the introduced change, wdyt?
On the other hand, since the Gutenberg PR added an entry to the changelog file, probably we should do the same in the release notes.

@jhnstn jhnstn changed the title Update Gutenberg submodule Fix missing Featured Image translations Jan 14, 2022
@jhnstn jhnstn mentioned this pull request Jan 14, 2022
Closed
@jhnstn jhnstn enabled auto-merge January 14, 2022 21:07
@jhnstn jhnstn disabled auto-merge January 14, 2022 21:07
@jhnstn jhnstn enabled auto-merge (squash) January 14, 2022 21:07
@jhnstn jhnstn merged commit 628e86f into develop Jan 14, 2022
@jhnstn jhnstn deleted the try/fix-editor-translations branch January 14, 2022 21:30
@fluiddot fluiddot mentioned this pull request Jan 20, 2022
Merged
4 tasks
@fluiddot
Copy link
Contributor

fluiddot commented Jan 25, 2022 •
edited
Loading

I noticed while testing the iOS beta version 19.1 (19.1.0.0) that the strings referenced in the Gutenberg PR are not translated. I guess this is caused by the fact that the strings have changed and localization files in WordPress-iOS haven't been updated yet (reference).

Not translated strings:

  • Set as Featured Image
  • Remove as Featured Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
i18n [OS] Android
Projects
None yet
Milestone
1.70.0 (19.1)
Development

Successfully merging this pull request may close these issues.
2 participants
@jhnstn @fluiddot