Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing Featured Image translations #4464

Merged
merged 9 commits into from
Jan 14, 2022
Merged

Fix missing Featured Image translations #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e1a29c
Update Gutenberg submodule
jhnstn Jan 13, 2022
c021d1d
Add both platform strings
jhnstn Jan 14, 2022
0ec2893
Revert debugging changes
jhnstn Jan 14, 2022
5821350
Correct platform strings
jhnstn Jan 14, 2022
a726254
Merge branch 'develop' into try/fix-editor-translations
jhnstn Jan 14, 2022
90f4990
Update release notes
jhnstn Jan 14, 2022
ebac03e
Update Gutenberg ref
jhnstn Jan 14, 2022
4005da1
Merge branch 'develop' into try/fix-editor-translations
jhnstn Jan 14, 2022
26d2a38
Merge branch 'develop' into try/fix-editor-translations
jhnstn Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Unreleased
* [**] Fix content justification attribute in Buttons block [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4451]
* [*] Hide help button from Unsupported Block Editor. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4352/]
* [*] Add contrast checker to text-based blocks [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4357]
* [*] Fix missing Featured Image translations [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4464]

1.69.0
---
Expand Down
4 changes: 2 additions & 2 deletions bundle/android/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ translators: %s: Select control button label e.g. "Button width" -->
<string name="gutenberg_native_problem_displaying_block" tools:ignore="UnusedResources">Problem displaying block</string>
<string name="gutenberg_native_problem_opening_the_audio" tools:ignore="UnusedResources">Problem opening the audio</string>
<string name="gutenberg_native_problem_opening_the_video" tools:ignore="UnusedResources">Problem opening the video</string>
<string name="gutenberg_native_remove_as_featured_image" tools:ignore="UnusedResources">Remove as Featured Image </string>
<string name="gutenberg_native_remove_as_featured_image" tools:ignore="UnusedResources">Remove as Featured Image</string>
<string name="gutenberg_native_remove_block" tools:ignore="UnusedResources">Remove block</string>
<string name="gutenberg_native_replace_audio" tools:ignore="UnusedResources">Replace audio</string>
<string name="gutenberg_native_replace_current_block" tools:ignore="UnusedResources">Replace Current Block</string>
Expand Down Expand Up @@ -311,7 +311,7 @@ translators: Block name. %s: The localized block name -->
<!-- translators: %s: Select font size option value e.g: "Selected: Large".
translators: %s: Select control option value e.g: "Auto, 25%". -->
<string name="gutenberg_native_selected_s" tools:ignore="UnusedResources">Selected: %s</string>
<string name="gutenberg_native_set_as_featured_image" tools:ignore="UnusedResources">Set as Featured Image </string>
<string name="gutenberg_native_set_as_featured_image" tools:ignore="UnusedResources">Set as Featured Image</string>
<string name="gutenberg_native_show_post_content" tools:ignore="UnusedResources">Show post content</string>
<!-- translators: Slash inserter autocomplete results -->
<string name="gutenberg_native_slash_inserter_results" tools:ignore="UnusedResources">Slash inserter results</string>
Expand Down
4 changes: 2 additions & 2 deletions bundle/ios/GutenbergNativeTranslations.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ private func dummy() {
_ = NSLocalizedString("Problem displaying block", comment: "")
_ = NSLocalizedString("Problem opening the audio", comment: "")
_ = NSLocalizedString("Problem opening the video", comment: "")
_ = NSLocalizedString("Remove as Featured Image ", comment: "")
_ = NSLocalizedString("Remove as Featured Image", comment: "")
_ = NSLocalizedString("Remove block", comment: "")
_ = NSLocalizedString("Replace audio", comment: "")
_ = NSLocalizedString("Replace Current Block", comment: "")
Expand All @@ -260,7 +260,7 @@ private func dummy() {
_ = NSLocalizedString("Select a layout", comment: "")
_ = NSLocalizedString("Selected: %s", comment: "translators: %s: Select font size option value e.g: \"Selected: Large\".\ntranslators: %s: Select control option value e.g: \"Auto, 25%\".")
_ = NSLocalizedString("Selected: Default", comment: "")
_ = NSLocalizedString("Set as Featured Image ", comment: "")
_ = NSLocalizedString("Set as Featured Image", comment: "")
_ = NSLocalizedString("Show post content", comment: "")
_ = NSLocalizedString("Slash inserter results", comment: "translators: Slash inserter autocomplete results")
_ = NSLocalizedString("Some blocks have additional settings. Tap the settings icon on the bottom right of the block to view more options.", comment: "")