[RNMobile] Retrieve translation of color settings strings #38026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
fluiddot
commented
Jan 17, 2022
| @@ -23,7 +28,7 @@ export const colorsUtils = { | |||
| picker: 'Picker', | |||
| palette: 'Palette', | |||
| }, | |||
| segments: [ 'Solid', 'Gradient' ], | |||
| segments: [ __( 'Solid' ), __( 'Gradient' ) ], | |||
There was a problem hiding this comment.
segments is being used in the Palette screen component:
Comment on lines
+12
to
+13
| { label: __( 'Linear' ), value: gradients.linear }, | ||
| { label: __( 'Radial' ), value: gradients.radial }, |
There was a problem hiding this comment.
gradientOptions is being used in Custom Gradient Picker component:
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
fluiddot
added
the
Mobile App - Automation
geriux
approved these changes
Jan 19, 2022
# Conflicts: # packages/react-native-editor/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4479
Description
The following strings located in
packages/components/src/mobile/color-settings/utils.native.jsfile were not translated because they weren't retrieving their translation texts:LinearRadialSolidGradientThis PR adds the
__function to those strings for getting their translations.How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).