Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Retrieve translation of color settings strings #38026

Merged
merged 3 commits into from
Jan 19, 2022
+9 −3
Merged

[RNMobile] Retrieve translation of color settings strings #38026

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7818221
Translate color settings strings
fluiddot Jan 17, 2022
7262643
Update react-native-editor changelog
fluiddot Jan 17, 2022
8e4b568
Merge branch 'trunk' into rnmobile/fix/translate-color-settings-strings
fluiddot Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/components/src/mobile/color-settings/utils.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';

const gradients = {
linear: 'linear-gradient',
radial: 'radial-gradient',
};

const gradientOptions = [
{ label: 'Linear', value: gradients.linear },
{ label: 'Radial', value: gradients.radial },
{ label: __( 'Linear' ), value: gradients.linear },
{ label: __( 'Radial' ), value: gradients.radial },
Comment on lines +12 to +13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradientOptions is being used in Custom Gradient Picker component:

gutenberg/packages/components/src/custom-gradient-picker/index.native.js

Line 31 in 3da717b

const { getGradientType, gradients, gradientOptions } = colorsUtils;

gutenberg/packages/components/src/custom-gradient-picker/index.native.js

Lines 94 to 97 in 3da717b

<PanelBody title={ __( 'Gradient Type' ) }>
<RadioControl
selected={ gradientType }
options={ gradientOptions }

];

const getGradientType = ( color ) => {
Expand All @@ -23,7 +28,7 @@ export const colorsUtils = {
picker: 'Picker',
palette: 'Palette',
},
segments: [ 'Solid', 'Gradient' ],
segments: [ __( 'Solid' ), __( 'Gradient' ) ],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

segments is being used in the Palette screen component:

gutenberg/packages/components/src/mobile/color-settings/palette.screen.native.js

Line 44 in 52f6290

const { segments, isGradient } = colorsUtils;

gutenberg/packages/components/src/mobile/color-settings/palette.screen.native.js

Lines 123 to 124 in 52f6290

<SegmentedControls
segments={ segments }

gradients,
gradientOptions,
getGradientType,
Expand Down