Enable shift in URLPopover component
#42214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
talldan,
andrewserong and
aaronrobertshaw
|
Size Change: +4 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 7, 2022
aaronrobertshaw
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Thanks for the fix @ntsekouras 👍
I could replicate the original issue and applying this PR's changes fixes the problem for me. Tested with the image, gallery, and social icons blocks.
Like you and Andrew, I'm not sure under what circumstances we'd not want to ensure the popover remains within the viewport. Until we have an answer to that, this seems like a nice quick win.
My only question is, should we also be tweaking the URLInput component as well?
The URLInput when adding a link to paragraph text can still be positioned outside the viewport as seen below. This can be done in a separate PR of course.
|
Thanks for the reviews!
We should see this in a separate PR because I saw some differences when inside an iframe(site editor), so needs more looking into the Popover internals. |
|
I'm late to the party, but thanks for fixing this one up @ntsekouras!
Happy to help review if you wind up pushing a PR to look at this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds makes URLPopover component to use the
shiftfunctionality which checks if the popover is within the viewport. I'm currently exploring some issues with the Popover and I'm still wondering where we should not want toshiftand made that change here.We might remove this flag in the future or change the default, or pass some more specific options to fine tune the shifting of some components..
Testing Instructions
URLPopovernear the edges of a viewport.Social Iconsblock, or theImageblock to insert link.Before
before.mov
After
after.mov