Fix: the description text of block movers for horizontal movement #42393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +631 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Closed
6 tasks
t-hamano
added
[Focus] Accessibility (a11y)
t-hamano
changed the title
talldan
reviewed
Jul 14, 2022
packages/block-editor/src/components/block-mover/mover-description.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-mover/mover-description.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-mover/mover-description.js
Outdated
Show resolved
Hide resolved
|
Added condition when all blocks are selected:
|
talldan
reviewed
Jul 14, 2022
packages/block-editor/src/components/block-mover/mover-description.js
Outdated
Show resolved
Hide resolved
…tion.js Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
|
It looks like there is no problem with what we have done so far, but I can't test it in RTL language. |
talldan
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Thanks for fixing this!
I tested in an RTL language and could reproduce the issue in trunk and also confirm that this solves the problem.
I tested quite a few different combinations (single block selections, multi-block selections and horizontal block selections) and couldn't see any further issues, so really nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of #32337
Fix: #25158
This PR is newly created to reflect the latest trunk in #32337 sent from
thisissandip:fix/block-mover-description-text.Description
The button to move the block has the following two accessibility attributes:
aria-label: indicates the direction to movearia-describedby: Indicates where to move to or whether to moveThis PR fixes a problem where the text indicated by
aria-describedbydoes not consider the orientation if the layout orientation is horizontal.How has this been tested?
Screenshots
Horizontal layout
Select the first two blocks
Select the two blocks in between
Select the last two blocks
Vertical layout
Select the first two blocks
Select the two blocks in between
Select the last two blocks
Types of changes
Bug fix
Checklist: