Jest Preset: Ignore is-plain-obj transformation
#43179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Aug 12, 2022
Sure thing! I think it's only the |
tyxla
force-pushed
the
move/esm-module-ignore-jest-preset
branch
from
fac982c
to
92675a9
Compare
Confirmed. Added changelog entries to both packages in 92675a9. Thanks, @gziolo! |
gziolo
approved these changes
Aug 12, 2022
gziolo
pushed a commit
that referenced
this pull request
Aug 12, 2022
* Jest Preset: Ignore is-plain-obj transformation * Add changelogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR moves the
is-plain-objtransform ignore rule to the jest default preset.Why?
is-plain-objis an ESM-only package and since ESM isn't fully supported by Jest, it's not able to run tests on components where that package is imported.How?
We already had a transform ignore rule, we're just moving it to
@wordpress/jest-preset-defaultin order for it to be consumed by other packages like@wordpress/scripts.Testing Instructions
Verify all unit tests still pass.