Jest Preset: Improve is-plain-obj transformation ignore
#43271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
tyxla
changed the title
is-plain-obj transformation ignore
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Looks good and we have confirmation from @herndlm in #43132 (comment) that it resolves the issue.
gziolo
pushed a commit
that referenced
this pull request
Aug 17, 2022
* Jest Preset: Improve is-plain-obj transformation ignore * Add changelogs
|
New |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the
is-plain-objtransform ignore rule, as a follow-up to #43179. See #43132 (comment)Why?
We need to support the cases where
is-plain-objis a dependency of a package that is a dependency of a project that uses@wordpress/scripts.How?
We're making the regex more flexible so it would ignore node modules but
is-plain-obj, regardless of where it is in the path.Testing Instructions