Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pattern categories for 6.2 #47270

Closed
wants to merge 12 commits into from
Closed

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 19, 2023

What?

Part of #44501

Why?

This addresses the remaining comments in the main description of #44501.

To confirm, this is the list of categories these changes are based on:

List of categories

Universal patterns (Available in both post/page and site editors)

  • Call to Action
    Sections whose purpose is to trigger a specific action.
  • Team
    A variety of designs to display your team members.
  • Testimonials
    Share reviews and feedback about your brand/business.
  • Services
    Briefly describe what your business does and how you can help.
  • Contact
    Display your contact information.
  • About
    
Introduce yourself.
  • Portfolio
    
Showcase your latest work.
  • Gallery
    
Different layouts for displaying images.
  • Media
    Different layouts containing video or audio.
  • Posts
    
Display your latest posts in lists, grids or other layouts.
  • Products
    
Display your store’s products in lists, grids or other layouts.

Site building patterns (Site editor only)

  • Footers
    
A variety of footer designs displaying information and site navigation.
  • Headers
    
A variety of header designs displaying your site title and navigation.
  • Post Content
    
Your post and page content.
  • Comments
    Different ways of displaying your post or page's comments.
  • Pagination
    
A variety of designs for navigating your posts.
  • Comment Pagination
    
A variety of designs to browse through a big list of comments.
  • Archive Headings
    
A variety of designs for your archive heading.
  • 404
    
A variety of designs for when a page cannot be found.
  • Search
    
Different layouts to display search results.

How?

Removed

  • Removed 6 categories:
  • Removed 'Banners' category:
    • 3 patterns are categorised as 'Banner', so these now need re-categorising:
      • Media and text in a full height container,
      • Media and text with image on the right,
      • Large header with text and a button
  • Removed 'Buttons', 'Columns', 'Query' categories:
    • There were no patterns in these categories
  • Removed 'Text' category:
    • 1 pattern needs recategorising - 'Quote'
  • Removed 'Featured' category:
    • 1 pattern needs recategorising - 'Call to Action'

The removed categories should also be removed from all pattern files, so they're no longer categorised with old categories.

Added

  • Added 'Products' - this needs to be populated with patterns.

Co-authored-by: Sarah Norris 1645628+mikachan@users.noreply.github.com

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2023-01-20 at 17 00 34

This was added only 2 months ago but it’s not in the list so…
No patterns registered
There are two categories with title “Posts”. This one has the name “query” and the other has the name “posts”. The “posts” one has patterns registered to it whereas “query” appears not to. Thus we removed the “query” one.
@getdave getdave added Needs Design Feedback Needs general design feedback. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Pattern Directory The Pattern Directory, a place to find patterns labels Jan 19, 2023
@annezazu
Copy link
Contributor

Wanting to just note the context of the Banner category: #44203

@mikachan
Copy link
Member

Wanting to just note the context of the Banner category: #44203

Thanks for that! With that context, it sounds like the Banner category should be included, so I've added it back here 7d9aabd.

@github-actions
Copy link

github-actions bot commented Jan 20, 2023

Flaky tests detected in 85576a2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3995119132
📝 Reported issues:

@getdave getdave marked this pull request as ready for review January 20, 2023 09:01
@getdave getdave changed the title [WIP] Update Pattern categories for 6.2 Update Pattern categories for 6.2 Jan 20, 2023
@ntsekouras
Copy link
Contributor

Thanks for the PR Dave! I think there are many misunderstanding in all these issues, mostly because it seems there is a clear confusion about what changes are needed in core, in Pattern Directory and how to sync/integrate/migrate the two.

See my comment for a bit more details: #44501 (comment)

@getdave
Copy link
Contributor Author

getdave commented Jan 21, 2023

Thanks for the PR Dave! I think there are many misunderstanding in all these issues, mostly because it seems there is a clear confusion about what changes are needed in core, in Pattern Directory and how to sync/integrate/migrate the two.

See my comment for a bit more details: #44501 (comment)

No worries. @mikachan and I were very confused and tried to follow the trail of comments. Hopefully the PR can act as a starting point if needed to amend the categories.

FYI that @mikachan has volunteered to take this over as I am focused on the Nav block list view for 6.2 🙇

@mikachan
Copy link
Member

I will close this PR based on @ntsekouras' comment here. However, it sounds like related improvements can still be made to the pattern categories, which I'm planning to continue to explore in #47275.

@mikachan mikachan closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Pattern Directory The Pattern Directory, a place to find patterns [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants