-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pattern categories for 6.2 #47270
Conversation
This was added only 2 months ago but it’s not in the list so…
No patterns registered
There are two categories with title “Posts”. This one has the name “query” and the other has the name “posts”. The “posts” one has patterns registered to it whereas “query” appears not to. Thus we removed the “query” one.
Wanting to just note the context of the Banner category: #44203 |
Flaky tests detected in 85576a2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3995119132
|
Thanks for the PR Dave! I think there are many misunderstanding in all these issues, mostly because it seems there is a clear confusion about what changes are needed in core, in Pattern Directory and how to sync/integrate/migrate the two. See my comment for a bit more details: #44501 (comment) |
No worries. @mikachan and I were very confused and tried to follow the trail of comments. Hopefully the PR can act as a starting point if needed to amend the categories. FYI that @mikachan has volunteered to take this over as I am focused on the Nav block list view for 6.2 🙇 |
I will close this PR based on @ntsekouras' comment here. However, it sounds like related improvements can still be made to the pattern categories, which I'm planning to continue to explore in #47275. |
What?
Part of #44501
Why?
This addresses the remaining comments in the main description of #44501.
To confirm, this is the list of categories these changes are based on:
List of categories
Universal patterns (Available in both post/page and site editors)
Sections whose purpose is to trigger a specific action.
A variety of designs to display your team members.
Share reviews and feedback about your brand/business.
Briefly describe what your business does and how you can help.
Display your contact information.
Introduce yourself.
Showcase your latest work.
Different layouts for displaying images.
Different layouts containing video or audio.
Display your latest posts in lists, grids or other layouts.
Display your store’s products in lists, grids or other layouts.
Site building patterns (Site editor only)
A variety of footer designs displaying information and site navigation.
A variety of header designs displaying your site title and navigation.
Your post and page content.
Different ways of displaying your post or page's comments.
A variety of designs for navigating your posts.
A variety of designs to browse through a big list of comments.
A variety of designs for your archive heading.
A variety of designs for when a page cannot be found.
Different layouts to display search results.
How?
Removed
The removed categories should also be removed from all pattern files, so they're no longer categorised with old categories.
Added
Co-authored-by: Sarah Norris 1645628+mikachan@users.noreply.github.com
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast