Refactores __ExperimentalOffCanvasEditor to OffCanvasEditor #47553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
the
[Type] Code Quality
|
Size Change: -8 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
draganescu
changed the title
|
Shouldn't we rename it here too? |
scruffian
reviewed
Jan 30, 2023
packages/block-editor/src/components/off-canvas-editor/README.md
Outdated
Show resolved
Hide resolved
scruffian
force-pushed
the
refactor/__ExperimentalOffCanvasEditor-to-OffCanvasEditor
branch
from
4f8d665
to
b49efd9
Compare
scruffian
deleted the
refactor/__ExperimentalOffCanvasEditor-to-OffCanvasEditor
branch
|
Flaky tests detected in b49efd9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4054245877
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Since exporting the
__ExperimentalOffCanvasEditorin #47465 wraps the component in an experiment that needs to be unlocked, the "__Experimental" prefix is not required anymore.Why?
Just code refactoring for a cleaner codebase.
How?
Renamed the component everywhere. I hope.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast