Shuffle contentOnly pattern blocks
#47594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Feature] Patterns
kevin940726
force-pushed
the
try/shuffle-content-only-pattern
branch
from
c72f87a
to
fbf75eb
Compare
|
Size Change: +3.58 kB (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Thanks for continuing to iterate on the shuffling behaviour @kevin940726 👍 It is testing as advertised for me. I don't have extensive history or context on these efforts but this PR feels like a good step towards an MVP from the discussion on the original PR (#45618). I'm also not clear on our plans for the What are the next steps to move this forward? |
|
I added a callback to "opt-out" of Kapture.2023-02-02.at.22.46.46.mp4This isn't ideal though, with some obvious drawbacks:
I'm not sure what the next steps are. I could use some recommendations to build the next MVP/draft PR to test other alternatives out. Perhaps someone with more knowledge of how the pattern block and |
|
Flaky tests detected in d056cc6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4076273009
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #45618. This PR adds
templateLockto the pattern block, and allows shuffling patterns forcontentOnlypattern blocks.Why?
See #44581.
How?
This PR does a couple of things:
templateLockto the pattern block. There is currently no way to edit this attribute in the user interface though, one will need to go to the code editor to manually add the"templateLock": "contentOnly"attribute to the pattern block.contentOnly. The logic looks for all the patterns with the samecategoriesand replaces the full content of the pattern.Testing Instructions
"templateLock": "contentOnly"to the pattern block. (Reload the page if there isn't a pattern block)Shufflebutton available in the block toolbar (if there are matched candidates to shuffle to).Testing Instructions for Keyboard
"templateLock": "contentOnly"to the pattern block. (Reload the page if there isn't a pattern block)Screenshots or screencast
Kapture.2023-01-31.at.14.58.24.mp4