Site editor: specify focus state color for template navigation button #48134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +10 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ac564a4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4195618851
|
glendaviesnz
approved these changes
Feb 17, 2023
|
Thank you for the review, @glendaviesnz! I'd like to merge if the performance test passes. |
To my understanding, the performance test failure is a known issue. @Mamaduka may know more. |
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 6881d6d |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 20, 2023
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #47851
What?
This PR sets the focus state color of template navigation back icon.
Why?
This style is overridden by WP Admin-style, but it should be displayed in white like the rest of the state.
Screenshot
Before
before.mp4
After
after.mp4