Fix site editor switch mode message. #48136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -5 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 01db636. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4202466865
|
Mamaduka
approved these changes
Feb 17, 2023
afercia
force-pushed
the
fix/site-editor-switch-mode-message
branch
from
ea152df
to
01db636
Compare
|
Performance tests were failing for unrelated (?) reasons. Restarted the job with no success. Rebased on top of latest trunk in the hope it unblocks the failing jobs. |
|
That’s a known issue, @afercia. |
|
Thanks @Mamaduka. I'm not sure I have the permissions to merge this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When switching the Site Editor mode from Visual editor to Code editor and vice-versa, an audible
speakmessage is supposed to be provided for screen reader users:gutenberg/packages/edit-site/src/store/actions.js
Lines 527 to 531 in 11525f7
Turns out there's no 'mosaic' mode so when switching to 'Code' nothing is announced.
To. my understanding, a 'Mosaic View' was tried in #33770 but the PR was closed and never merged. Nonetheless, the reference to a 'mosaic' mode was added in #37765
Why?
A proper audible message should be provided when switching to Code mode.
How?
Fixes the mode value used for a conditional and changes the related translatable string.
Testing Instructions
a11y-speak-assertiveis:Code editor selected.a11y-speak-assertiveis:Visual editor selected.Testing Instructions for Keyboard
Screenshots or screencast