Combine tests for checking for a navigable toolbar into one test to improve performance #51550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove performance
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
|
Flaky tests detected in fe35de5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5282256427
|
Mamaduka
approved these changes
Jun 20, 2023
|
@scruffian, the PR description has a note to hold off merging this until the #51548 is merged. |
|
It merged into |
jeryj
added a commit
that referenced
this pull request
Jun 22, 2023
…s a form element (#51548) There was a bug in the tab navigation that allowed tabbing between form elements within a block. Shift + tab in this instance should move to the preceding tabbable element within the current block. However, it wasn't checking if the preceding form element was _within_ the current block, so when at the block boundary, a shift+tab would move to the preceding block's form element rather than the block toolbar. This changes the behavior to constrain the form elements _within the selected block_ and only handle shift+tab or tab if the element being tabbed to is within the current block. * Combine tests for checking for a navigable toolbar into one test to improve performance (#51550)
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…s a form element (WordPress#51548) There was a bug in the tab navigation that allowed tabbing between form elements within a block. Shift + tab in this instance should move to the preceding tabbable element within the current block. However, it wasn't checking if the preceding form element was _within_ the current block, so when at the block boundary, a shift+tab would move to the preceding block's form element rather than the block toolbar. This changes the behavior to constrain the form elements _within the selected block_ and only handle shift+tab or tab if the element being tabbed to is within the current block. * Combine tests for checking for a navigable toolbar into one test to improve performance (WordPress#51550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Taking several related tests and combining into one test to save time on running tests.
This needs to wait to be merged until #51548 lands, as combining these tests uncovered a real bug in the keyboard navigation behavior.
Testing Instructions
npm run test:e2e:playwright test/e2e/specs/editor/various/toolbar-roving-tabindex.spec.js