List View: Ensure onBlockDrop does not fire if there is no target #52959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
andrewserong
requested review from
noisysocks,
apeatling,
ramonjd and
tellthemachines
andrewserong
changed the title
|
Size Change: +5 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Jul 26, 2023
|
Thanks for reviewing! I think it's a fairly uncommon / difficult thing to reproduce due to it being a subtle race condition that's usually resolved within about |
andrewserong
deleted the
fix/list-view-blocks-flicking-to-the-bottom-on-rapid-click
branch
ramonjd
pushed a commit
that referenced
this pull request
Jul 28, 2023
|
I just cherry-picked this PR to the update/packages-wp-6-3-RC3 branch to get it included in the next release: 12fcd6b |
ramonjd
removed
the
Backport to WP 6.7 Beta/RC
ramonjd
added a commit
that referenced
this pull request
Jul 28, 2023
* Patterns: Enable focus mode editing (#52427) * PreventDefault when isComposing is true. apply patch from t-hamano. (#52844) see: #52821 (comment) * List View: Ensure onDrop does not fire if there is no target (#52959) * I18N: Add missing Gettext wrapper on strings in Edit Post overview sidebar (#52971) * I18N: Add missing gettext wrapper * Add context to disambiguate 'Outline' that is commonly used on borders. * Footnotes: disable based on post type (#52934) * Footnotes: disable based on post type * Address feedback * Fix typo * Format: disable if block is not registered * Lock usesContext api * Use Symbol instead of Math.random * Patterns Browse Screen: Fix back button when switching between categories (#52964) * Patterns: Allow orphaned template parts to appear in general category (#52961) * Spacing presets: fix bug with select control adding undefined preset values (#53005) * Site Editor: Fix canvas mode sync with URL (#52996) * Check if spacing tool is defined before displaying controls. (#53008) * Check if spacing tool is defined before displaying controls. * Don't show sides if spacing type false * Improve consistency of the Post editor and Site editor Document actions (#52246) * Remove redundant shortcut button. * Fix focus and hover style and improve consistency. * Rename post document-title and improve CSS consistency. * Site Editor: Fix the typo in the title label map (#53071) * Fix patterns search crash: check for existence of defaultView before attempting to get styles (#52956) * backport paging bug fixes (#53091) --------- Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Hiroshi Urabe <mail@torounit.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Pedro Mendonça <ped.gaspar@gmail.com> Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: tellthemachines <tellthemachines@users.noreply.github.com> Co-authored-by: Andrea Fercia <a.fercia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #52919
Fix issue with the List View's drag-and-drop where sometimes blocks would suddenly be sent down to the bottom of the document when clicking around quickly.
Why?
From some logging out of values, what appears to be happening on
trunkis that if you click on a selected block very rapidly with a little bit of movement, sometimes anonDragEndcallback is fired (which setstargettonull), before theonDropcallback is fired.What's expected to happen is that dragging on a selected block will effectively result in no moving of blocks occurring because the target is the same as what's being dragged over. However, the code that determines the desired target is throttled to
200ms, so if you go to drag a block and within that200msperform another drag, it's possible to fire that second drag after the firstdragEndevent has cleared out thetargetand before theonDragOvergives us a new target.I'm not 100% that this is exactly what's happening, but what I've observed is that if you're clicking around very quickly on a selected block, it seems that you can accidentally drag a block and rapidly start another drag in the same position, and due to this issue of
targetbeing set tonullfor a short time, the block winds up being sent all the way to the bottom.To resolve this issue (which seems to be something of a race condition to me), we can check that the target is truthy before allowing a drop to occur.
How?
Within the
onDropcallback, check that thetargetis truthy before allowingonBlockDropto be called. This should be pretty safe as the list view drag and drop behaviour expects that there is a target set for any kind of drop to occur.Testing Instructions
trunktargetdoesn't interrupt drag events that are not about rearranging existing blocks)Screenshots or screencast