Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18N: Add missing Gettext wrapper on strings in Edit Post overview sidebar #52971

Merged
merged 2 commits into from
Jul 26, 2023
Merged

I18N: Add missing Gettext wrapper on strings in Edit Post overview sidebar #52971

merged 2 commits into from
Jul 26, 2023

Conversation

pedro-mendonca
Copy link
Contributor

What?

Fix i18n on strings in Edit Post overview sidebar

Why?

To be able to translate "List View" and "Outline" in Post editor overview sidebar tabs

How?

Added _x() with context to avoid confusion with common "Outline" strings used everywhere else in border styling context.

Testing Instructions

  1. Build and update translation files to include the new "List View" and "Outline" strings with context.
  2. Set a language on Settings > General other than English (US).
  3. Add new post
  4. Click on the overview icon on the top toolbar on the left
  5. See both tabs titles translated.

Fixes #52970

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts labels Jul 26, 2023
Mamaduka
Mamaduka approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pedro-mendonca!

I belive this needs to be backported into 6.3.

@Mamaduka Mamaduka added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 26, 2023
@pedro-mendonca
Copy link
Contributor Author

I agree, it's already a problem on WP 6.3 RC.

@pedro-mendonca
Copy link
Contributor Author

pedro-mendonca commented Jul 26, 2023 •
edited
Loading

The issue with the context of "Outline" should also be backported to previous WP versions. Just tested and the issue was introduced in 75dfcf0 on WP 6.2.
The single word string "Outline" has so many meanings and uses... in WP it's mostly used for border styiling. Shouldn't be left without any context.

@Mamaduka Mamaduka merged commit 3d2bffd into WordPress:trunk Jul 26, 2023
49 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 26, 2023
ramonjd pushed a commit that referenced this pull request Jul 28, 2023
@pedro-mendonca @ramonjd
I18N: Add missing Gettext wrapper on strings in Edit Post overview si…
382f4bb 
…debar (#52971)

* I18N: Add missing gettext wrapper

* Add context to disambiguate 'Outline' that is commonly used on borders.
@ramonjd
Copy link
Member

ramonjd commented Jul 28, 2023

I just cherry-picked this PR to the update/packages-wp-6-3-RC3 branch to get it included in the next release: 382f4bb

@ramonjd ramonjd removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 28, 2023
@ramonjd ramonjd mentioned this pull request Jul 28, 2023
Merged
ramonjd added a commit that referenced this pull request Jul 28, 2023
@ramonjd @Mamaduka
@torounit @andrewserong @pedro-mendonca @ellatrix @aaronrobertshaw @glendaviesnz @tellthemachines @afercia
Package update: bugfixes for 6.3 RC3 (#53089)
dc4ff68 
* Patterns: Enable focus mode editing (#52427)

* PreventDefault when isComposing is true. apply patch from t-hamano. (#52844)

see: #52821 (comment)

* List View: Ensure onDrop does not fire if there is no target (#52959)

* I18N: Add missing Gettext wrapper on strings in Edit Post overview sidebar (#52971)

* I18N: Add missing gettext wrapper

* Add context to disambiguate 'Outline' that is commonly used on borders.

* Footnotes: disable based on post type (#52934)

* Footnotes: disable based on post type

* Address feedback

* Fix typo

* Format: disable if block is not registered

* Lock usesContext api

* Use Symbol instead of Math.random

* Patterns Browse Screen: Fix back button when switching between categories (#52964)

* Patterns: Allow orphaned template parts to appear in general category (#52961)

* Spacing presets: fix bug with select control adding undefined preset values (#53005)

* Site Editor: Fix canvas mode sync with URL (#52996)

* Check if spacing tool is defined before displaying controls. (#53008)

* Check if spacing tool is defined before displaying controls.

* Don't show sides if spacing type false

* Improve consistency of the Post editor and Site editor Document actions (#52246)

* Remove redundant shortcut button.

* Fix focus and hover style and improve consistency.

* Rename post document-title and improve CSS consistency.

* Site Editor: Fix the typo in the title label map (#53071)

* Fix patterns search crash: check for existence of defaultView before attempting to get styles (#52956)

* backport paging bug fixes (#53091)

---------

Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Co-authored-by: Hiroshi Urabe <mail@torounit.com>
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
Co-authored-by: Pedro Mendonça <ped.gaspar@gmail.com>
Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com>
Co-authored-by: tellthemachines <tellthemachines@users.noreply.github.com>
Co-authored-by: Andrea Fercia <a.fercia@gmail.com>
@mikachan mikachan added the [Package] Edit Post /packages/edit-post label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Edit Post /packages/edit-post [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.3.x Editor Tasks
Status: ✅ Done
Milestone
Gutenberg 16.4
Development

Successfully merging this pull request may close these issues.

Missing i18n on strings in Edit Post overview sidebar
4 participants
@pedro-mendonca @ramonjd @Mamaduka @mikachan